Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1228)

Issue 59560044: Add jenv file path to the GUI login help text.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by frankban
Modified:
10 years, 1 month ago
Reviewers:
mp+204503, gary.poster
Visibility:
Public.

Description

Add jenv file path to the GUI login help text. Change the GUI login message to give exact jenv file to look in for the admin secret, if the environment name is available in the hook's context. Tests: `make unittest`. QA: 1) bootstrap a stable juju-core; 2) deploy this branch with `make deploy`; 3) open the GUI: the login message should point you generically to the path where to find the jenv files; 4) destroy the environment; 5) bootstrap juju-core trunk (at least revno 2289); 6) deploy this branch with `make deploy`; 7) open the GUI: the login message should point you to the exact path to the jenv file; 8) now execute "juju set juju-gui login-help=HELP!", and wait a couple of seconds; 9) open the GUI again and you should see the new message; 10) destroy the environment. Done, thank you! https://code.launchpad.net/~frankban/charms/precise/juju-gui/use-env-name/+merge/204503 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add jenv file path to the GUI login help text. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -6 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M config.yaml View 1 chunk +2 lines, -4 lines 0 comments Download
M hooks/backend.py View 1 chunk +1 line, -1 line 0 comments Download
M hooks/utils.py View 1 1 chunk +29 lines, -0 lines 0 comments Download
M revision View 1 chunk +1 line, -1 line 0 comments Download
M tests/test_utils.py View 1 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 4
frankban
Please take a look.
10 years, 1 month ago (2014-02-03 14:37:16 UTC) #1
gary.poster
LGTM and QA OK with consideration of suggested text changes. Thank you! Gary https://codereview.appspot.com/59560044/diff/1/hooks/utils.py File ...
10 years, 1 month ago (2014-02-03 15:39:45 UTC) #2
frankban
*** Submitted: Add jenv file path to the GUI login help text. Change the GUI ...
10 years, 1 month ago (2014-02-03 16:59:24 UTC) #3
frankban
10 years, 1 month ago (2014-02-03 17:01:04 UTC) #4
Thank you!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b