Implement maas-name constraint

Implement maas-name constraint

Descended from lp:~julian-edwards/juju/name-constraints; but uses new-style
constraints registration.

Also uses a custom ubuntu-series constraint to forbid use of charms written
for systems we can't yet provision with MAAS.

https://code.launchpad.net/~fwereade/juju/maas-name-constraint/+merge/99746

Requires: https://code.launchpad.net/~fwereade/juju/constraints-get/+merge/99704

(do not edit description out of merge proposal)

[fwereade, 2012-03-28 14:46:46]

Please take a look.

[allenap, 2012-03-28 15:09:20]

On 2012/03/28 14:46:46, fwereade wrote:
> Please take a look.

Looks sensible to me.

[hazmat, 2012-03-28 18:10:47]

LGTM

https://codereview.appspot.com/5938050/diff/1/juju/environment/config.py
File juju/environment/config.py (right):

https://codereview.appspot.com/5938050/diff/1/juju/environment/config.py#newc...
juju/environment/config.py:68: "default-series": Constant("precise")},
deserves a comment regarding maas limitation in this regard.

https://codereview.appspot.com/5938050/diff/1/juju/environment/tests/test_con...
File juju/environment/tests/test_config.py (right):

https://codereview.appspot.com/5938050/diff/1/juju/environment/tests/test_con...
juju/environment/tests/test_config.py:681: self.assertRaises(
it would be nice to check this error message for its end user usability. the
nicely messaged value error in the provider doesn't really ever get surfaced to
the user, but this one does.

[fwereade, 2012-03-28 18:21:58]

https://codereview.appspot.com/5938050/diff/1/juju/environment/config.py
File juju/environment/config.py (right):

https://codereview.appspot.com/5938050/diff/1/juju/environment/config.py#newc...
juju/environment/config.py:68: "default-series": Constant("precise")},
On 2012/03/28 18:10:47, hazmat wrote:
> deserves a comment regarding maas limitation in this regard.

Done.

https://codereview.appspot.com/5938050/diff/1/juju/environment/tests/test_con...
File juju/environment/tests/test_config.py (right):

https://codereview.appspot.com/5938050/diff/1/juju/environment/tests/test_con...
juju/environment/tests/test_config.py:681: self.assertRaises(
On 2012/03/28 18:10:47, hazmat wrote:
> it would be nice to check this error message for its end user usability. the
> nicely messaged value error in the provider doesn't really ever get surfaced
to
> the user, but this one does.

Good catch, thank you. Done.

[fwereade, 2012-03-28 19:06:28]

*** Submitted:

Implement maas-name constraint

Descended from lp:~julian-edwards/juju/name-constraints; but uses new-style
constraints registration.

Also uses a custom ubuntu-series constraint to forbid use of charms written
for systems we can't yet provision with MAAS.

R=allenap, hazmat
CC=
https://codereview.appspot.com/5938050