Issue 5933058: Small fixes:

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5933058: Small fixes:

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by fwereade

Modified:
12 years, 1 month ago

Reviewers:
mp+99810

Visibility:
Public.

Description

Small fixes: * Private EC2 clouds no longer expose constraints * deploy/add-unit no longer pointlessly warn about legacy keys which remain necessary in legacy environments https://code.launchpad.net/~fwereade/juju/private-cloud-fixes/+merge/99810 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Small fixes: #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -43 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/control/legacy.py	View	1 chunk	+10 lines, -25 lines	0 comments	Download
M	juju/control/tests/test_add_unit.py	View	1 chunk	+3 lines, -6 lines	0 comments	Download
M	juju/control/tests/test_deploy.py	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	juju/providers/ec2/__init__.py	View	1 chunk	+9 lines, -4 lines	0 comments	Download
M	juju/providers/ec2/tests/test_provider.py	View	2 chunks	+12 lines, -1 line	0 comments	Download
M	juju/providers/ec2/utils.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fwereade

12 years, 1 month ago (2012-03-28 20:07:45 UTC) #3

*** Submitted:

Small fixes:

* Private EC2 clouds no longer expose constraints
* deploy/add-unit no longer pointlessly warn about legacy keys which remain
  necessary in legacy environments

R=hazmat
CC=
https://codereview.appspot.com/5933058

Expand All Messages | Collapse All Messages