Issue 59290045: Add an option to initialize varyings without static use in vertex shaders

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 59290045: Add an option to initialize varyings without static use in vertex shaders

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by Zhenyao Mo

Modified:
10 years, 2 months ago

Reviewers:
kbr1, nicolascapens

CC:
angleproject-review_googlegroups.com, Alok Priyadarshi, Shannon Woods

Base URL:
https://chromium.googlesource.com/angle/angle@master

Visibility:
Public.

More Reviews

Description

Add an option to initialize varyings without static use in vertex shaders TEST=webgl conformance test on mac: shaders-with-varyings.html R=kbr@chromium.org,nicolascapens@chromium.org ANGLEBUG=554 BUG=554

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+220 lines, -108 lines)			Patch
M	include/GLSLANG/ShaderLang.h	View	2 chunks	+8 lines, -2 lines	0 comments	Download
	src/compiler/translator/Compiler.cpp	View	4 chunks	+67 lines, -5 lines	0 comments	Download
D	src/compiler/translator/InitializeGLPosition.h	View	1 chunk	+0 lines, -33 lines	0 comments	Download
	src/compiler/translator/InitializeGLPosition.cpp	View	1 chunk	+0 lines, -61 lines	0 comments	Download
	src/compiler/translator/InitializeVariables.h	View	2 chunks	+23 lines, -7 lines	0 comments	Download
A	src/compiler/translator/InitializeVariables.cpp	View	1 chunk	+107 lines, -0 lines	0 comments	Download
M	src/compiler/translator/ShHandle.h	View	1 chunk	+10 lines, -0 lines	0 comments	Download
	src/compiler/translator/VariableInfo.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/translator/VariableInfo.cpp	View	3 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Zhenyao Mo

10 years, 2 months ago (2014-02-11 00:03:28 UTC) #1

ken or nicolas: could you please take a look?
Alok and Shannon: FYI

Shannon, is my setup wrong so I ended up uploading CL here? Do you know how I
fix this?

This CL is tested with float/vec/matrix and scaler/array.  It's all working
fine.

Expand All Messages | Collapse All Messages