Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(116)

Issue 59240043: code review 59240043: time: use names for beginning and end of zone transitio... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by iant
Modified:
11 years, 5 months ago
Reviewers:
minux1, gobot, r, dave
CC:
golang-codereviews, r
Visibility:
Public.

Description

time: use names for beginning and end of zone transition times No functional changes, just more readable code.

Patch Set 1 #

Patch Set 2 : diff -r 731cd4eca133 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
M src/pkg/time/zoneinfo.go View 5 chunks +15 lines, -8 lines 0 comments Download
M src/pkg/time/zoneinfo_plan9.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/time/zoneinfo_read.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/time/zoneinfo_windows.go View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7
iant
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 5 months ago (2014-01-31 22:56:35 UTC) #1
gobot
R=r@golang.org (assigned by iant@golang.org)
11 years, 5 months ago (2014-02-01 00:12:48 UTC) #2
r
LGTM thanks
11 years, 5 months ago (2014-02-01 00:57:32 UTC) #3
iant
*** Submitted as https://code.google.com/p/go/source/detail?r=e5b12367190b *** time: use names for beginning and end of zone transition ...
11 years, 5 months ago (2014-02-01 01:22:14 UTC) #4
gobot
This CL appears to have broken the freebsd-386 builder.
11 years, 5 months ago (2014-02-01 01:27:43 UTC) #5
minux1
On Fri, Jan 31, 2014 at 8:27 PM, <gobot@golang.org> wrote: > This CL appears to ...
11 years, 5 months ago (2014-02-01 02:57:11 UTC) #6
dave_cheney.net
11 years, 5 months ago (2014-02-01 03:12:00 UTC) #7
I've seen this failure before with both freebsd platforms.


On Sat, Feb 1, 2014 at 1:56 PM, minux <minux.ma@gmail.com> wrote:

>
> On Fri, Jan 31, 2014 at 8:27 PM, <gobot@golang.org> wrote:
>
>> This CL appears to have broken the freebsd-386 builder.
>
> now that the freebsd/386 builder is flaky too?
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b