Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(558)

Issue 59220049: code review 59220049: runtime: fix mem profile when both large and small obje... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by dvyukov
Modified:
11 years, 4 months ago
Reviewers:
gobot, rsc
CC:
golang-codereviews, rsc
Visibility:
Public.

Description

runtime: fix mem profile when both large and small objects are allocated at the same stack Currently small and large (size>rate) objects are merged into a single entry. But rate adjusting is required only for small objects. As a result pprof either incorrectly adjusts large objects or does not adjust small objects. With this change objects of different sizes are stored in different buckets.

Patch Set 1 #

Patch Set 2 : diff -r ec5195954667 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r ec5195954667 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 798c2c748a26 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M src/pkg/runtime/mprof.goc View 1 2 3 6 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 6
dvyukov
Hello golang-dev@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
11 years, 4 months ago (2014-02-09 08:44:41 UTC) #1
gobot
Replacing golang-dev with golang-codereviews. To the author of this CL: If you are using 'hg ...
11 years, 4 months ago (2014-02-12 16:45:29 UTC) #2
gobot
R=rsc@golang.org (assigned by dvyukov@google.com)
11 years, 4 months ago (2014-02-12 18:38:12 UTC) #3
rsc
LGTM
11 years, 4 months ago (2014-02-12 18:47:05 UTC) #4
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=1fa6b302ff1f *** runtime: fix mem profile when both large and small objects ...
11 years, 4 months ago (2014-02-14 09:20:54 UTC) #5
gobot
11 years, 4 months ago (2014-02-14 10:56:15 UTC) #6
Message was sent while issue was closed.
This CL appears to have broken the linux-arm-cheney-panda builder.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b