Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(87)

Issue 59210044: code review 59210044: unicode: delete appearance of unused LowerUpper term fr... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by r
Modified:
11 years, 5 months ago
Reviewers:
gobot, dave
CC:
golang-codereviews, dave_cheney.net
Visibility:
Public.

Description

unicode: delete appearance of unused LowerUpper term from comment If a LowerUpper ever happens, maketables will complain. Fixes issue 7002.

Patch Set 1 #

Patch Set 2 : diff -r 1492d8bf4998 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/unicode/letter.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
r
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 5 months ago (2014-01-31 23:08:16 UTC) #1
dave_cheney.net
LGTM. Thank you. On Sat, Feb 1, 2014 at 10:08 AM, <r@golang.org> wrote: > Reviewers: ...
11 years, 5 months ago (2014-01-31 23:08:59 UTC) #2
r
*** Submitted as https://code.google.com/p/go/source/detail?r=731cd4eca133 *** unicode: delete appearance of unused LowerUpper term from comment If ...
11 years, 5 months ago (2014-01-31 23:10:04 UTC) #3
gobot
This CL appears to have broken the linux-amd64 builder.
11 years, 5 months ago (2014-01-31 23:13:39 UTC) #4
dave_cheney.net
11 years, 5 months ago (2014-01-31 23:16:18 UTC) #5
Known issue, https://code.google.com/p/go/issues/detail?id=7205


On Sat, Feb 1, 2014 at 10:13 AM, <gobot@golang.org> wrote:

> This CL appears to have broken the linux-amd64 builder.
>
> https://codereview.appspot.com/59210044/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b