code review 59160044: syscall: regenerate Flock_t to make it compliant with EABI

syscall: regenerate Flock_t to make it compliant with EABI

Note that current z-files for linux/amd64,386,arm are based on 3.2 kernel.

[mikio, 2014-02-09 02:46:05]

Hello golang-codereviews@googlegroups.com (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2014-02-09 02:49:46]

On 2014/02/09 02:46:05, mikio wrote:
> Hello mailto:golang-codereviews@googlegroups.com (cc:
> mailto:golang-codereviews@googlegroups.com),
> 
> I'd like you to review this change to
> https://code.google.com/p/go

Is it possible to add a test for Flock to consistency_unix_test.go ?

[bradfitz, 2014-02-09 03:11:35]

How did you make this?
 On Feb 8, 2014 6:46 PM, <mikioh.mikioh@gmail.com> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com (cc:
> golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> syscall: regenerate Flock_t to make it compliant with EABI
>
> Note that current z-files for linux/amd64,386,arm are based on 3.2
> kernel.
>
> Please review this at https://codereview.appspot.com/59160044/
>
> Affected files (+7, -5 lines):
>   M src/pkg/syscall/ztypes_linux_arm.go
>
>
> Index: src/pkg/syscall/ztypes_linux_arm.go
> ===================================================================
> --- a/src/pkg/syscall/ztypes_linux_arm.go
> +++ b/src/pkg/syscall/ztypes_linux_arm.go
> @@ -145,11 +145,13 @@
>  }
>
>  type Flock_t struct {
> -       Type   int16
> -       Whence int16
> -       Start  int64
> -       Len    int64
> -       Pid    int32
> +       Type      int16
> +       Whence    int16
> +       Pad_cgo_0 [4]byte
> +       Start     int64
> +       Len       int64
> +       Pid       int32
> +       Pad_cgo_1 [4]byte
>  }
>
>  type RawSockaddrInet4 struct {
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[mikio, 2014-02-09 03:17:00]

simply un mkall.sh on linux/versatilepb-eabi+qemu.
how about your case?

On Sun, Feb 9, 2014 at 12:11 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> How did you make this?
>
> On Feb 8, 2014 6:46 PM, <mikioh.mikioh@gmail.com> wrote:
>>
>> Reviewers: golang-codereviews,
>>
>> Message:
>> Hello golang-codereviews@googlegroups.com (cc:
>> golang-codereviews@googlegroups.com),
>>
>> I'd like you to review this change to
>> https://code.google.com/p/go
>>
>>
>> Description:
>> syscall: regenerate Flock_t to make it compliant with EABI
>>
>> Note that current z-files for linux/amd64,386,arm are based on 3.2
>> kernel.
>>
>> Please review this at https://codereview.appspot.com/59160044/
>>
>> Affected files (+7, -5 lines):
>>   M src/pkg/syscall/ztypes_linux_arm.go
>>
>>
>> Index: src/pkg/syscall/ztypes_linux_arm.go
>> ===================================================================
>> --- a/src/pkg/syscall/ztypes_linux_arm.go
>> +++ b/src/pkg/syscall/ztypes_linux_arm.go
>> @@ -145,11 +145,13 @@
>>  }
>>
>>  type Flock_t struct {
>> -       Type   int16
>> -       Whence int16
>> -       Start  int64
>> -       Len    int64
>> -       Pid    int32
>> +       Type      int16
>> +       Whence    int16
>> +       Pad_cgo_0 [4]byte
>> +       Start     int64
>> +       Len       int64
>> +       Pid       int32
>> +       Pad_cgo_1 [4]byte
>>  }
>>
>>  type RawSockaddrInet4 struct {
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "golang-codereviews" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-codereviews+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.

[dave_cheney.net, 2014-02-09 03:18:57]

I don't feel comfortable changing this struct unless there is a test in place
that shows that the current definition is broken, or the new definition is not.

[gobot, 2014-02-12 17:01:51]

R=iant@golang.org (assigned by mikioh.mikioh@gmail.com)

[mikio, 2014-02-12 17:04:41]

just sent cl 58660044

On Sun, Feb 9, 2014 at 12:18 PM,  <dave@cheney.net> wrote:
> I don't feel comfortable changing this struct unless there is a test in
> place that shows that the current definition is broken, or the new
> definition is not.
>
> https://codereview.appspot.com/59160044/

[iant, 2014-02-12 22:37:48]

LGTM

When the test is in.

[mikio, 2014-02-24 16:37:06]

*** Submitted as https://code.google.com/p/go/source/detail?r=24a912aaf332 ***

syscall: regenerate Flock_t to make it compliant with EABI

Note that current z-files for linux/amd64,386,arm are based on 3.2 kernel.

LGTM=iant
R=golang-codereviews, dave, bradfitz, gobot, iant
CC=golang-codereviews
https://codereview.appspot.com/59160044

[gobot, 2014-02-25 02:28:08]

This CL appears to have broken the plan9-386-cnielsen builder.