Issue 5913043: Implement orchestra-classes constraint

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5913043: Implement orchestra-classes constraint

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by fwereade

Modified:
13 years, 8 months ago

Reviewers:
mp+99433

Visibility:
Public.

Description

Implement orchestra-classes constraint Really not much to see here... note that it *has* been experimentally verified that, for some reason, find_systems takes "classes like this" instead of ["classes", "like", "this"]. Yay, cobbler. https://code.launchpad.net/~fwereade/juju/orchestra-classes/+merge/99433 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Implement orchestra-classes constraint #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -97 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/machine/constraints.py	View		2 chunks	+0 lines, -3 lines	0 comments	Download
M	juju/machine/tests/test_constraints.py	View	1	4 chunks	+0 lines, -59 lines	0 comments	Download
M	juju/providers/orchestra/cobbler.py	View	1	2 chunks	+17 lines, -7 lines	0 comments	Download
M	juju/providers/orchestra/launch.py	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	juju/providers/orchestra/tests/common.py	View		1 chunk	+5 lines, -3 lines	0 comments	Download
M	juju/providers/orchestra/tests/test_cobbler.py	View		14 chunks	+17 lines, -16 lines	0 comments	Download
M	juju/providers/orchestra/tests/test_launch.py	View		4 chunks	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

hazmat

lgtm +1 https://codereview.appspot.com/5913043/diff/1/juju/providers/orchestra/cobbler.py File juju/providers/orchestra/cobbler.py (right): https://codereview.appspot.com/5913043/diff/1/juju/providers/orchestra/cobbler.py#newcode120 juju/providers/orchestra/cobbler.py:120: raise ProviderError("Could not find any Cobbler systems ...

13 years, 8 months ago (2012-03-26 22:21:03 UTC) #2

fwereade

13 years, 8 months ago (2012-03-26 22:35:03 UTC) #3

*** Submitted:

Implement orchestra-classes constraint

Really not much to see here... note that it *has* been experimentally
verified that, for some reason, find_systems takes "classes like this"
instead of ["classes", "like", "this"]. Yay, cobbler.

R=hazmat
CC=
https://codereview.appspot.com/5913043

Expand All Messages | Collapse All Messages