Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(349)

Issue 5905052: Directs displaying-grob-ancestry.ly to stderr (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by PhilEHolmes
Modified:
7 years, 2 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

This is effectively a proof-of-concept patch to send the output from the above snippet to stderr rather than stdout as at present. As ever, it's to reduce make doc clutter. This patch should apply and work. A real patch will involve editing snippets/new and running makelsr. I know very little about Guile/scheme, so if there is a better way of doing this I'd be happy to be told.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Documentation/snippets/displaying-grob-ancestry.ly View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 8
PhilEHolmes
Please review
7 years, 3 months ago (2012-03-25 13:59:31 UTC) #1
dak
http://codereview.appspot.com/5905052/diff/1/Documentation/snippets/displaying-grob-ancestry.ly File Documentation/snippets/displaying-grob-ancestry.ly (right): http://codereview.appspot.com/5905052/diff/1/Documentation/snippets/displaying-grob-ancestry.ly#newcode198 Documentation/snippets/displaying-grob-ancestry.ly:198: (format (current-error-port) "~a" That's silly. Just make a single ...
7 years, 3 months ago (2012-03-25 14:01:37 UTC) #2
mail_philholmes.net
----- Original Message ----- From: <dak@gnu.org> To: <PhilEHolmes@googlemail.com>; <graham@percival-music.ca>; <julien.rioux@gmail.com> Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org> Sent: Sunday, ...
7 years, 3 months ago (2012-03-25 14:25:23 UTC) #3
Keith
LGTM Just for clarity for patch-tracking, the 'silly' comment refers to the existing code, not ...
7 years, 3 months ago (2012-03-25 18:36:26 UTC) #4
dak
On 2012/03/25 18:36:26, Keith wrote: > LGTM > > Just for clarity for patch-tracking, the ...
7 years, 3 months ago (2012-03-25 19:03:27 UTC) #5
Keith
http://codereview.appspot.com/5905052/diff/1/Documentation/snippets/displaying-grob-ancestry.ly File Documentation/snippets/displaying-grob-ancestry.ly (right): http://codereview.appspot.com/5905052/diff/1/Documentation/snippets/displaying-grob-ancestry.ly#newcode203 Documentation/snippets/displaying-grob-ancestry.ly:203: Adapted from Ian and tested: #(define (display-ancestry grob) (format ...
7 years, 3 months ago (2012-03-25 20:19:42 UTC) #6
Mark Polesky
Hey guys, I don't want to be presumptuous here, but is there any chance I ...
7 years, 3 months ago (2012-03-26 15:29:46 UTC) #7
Graham Percival
7 years, 3 months ago (2012-03-26 20:46:47 UTC) #8
On Mon, Mar 26, 2012 at 03:29:46PM +0000, markpolesky@gmail.com wrote:
> I don't want to be presumptuous here, but is there any
> chance I can be credited for the original idea?  Or is
> that not typically done in the snippets directory?

We don't do this -- at least, we certainly don't have user-visible
names.  At one point I suggested that there could be a comment
"%LSR: created by XYZ" in the .ly portion inside the database, but
we would remove that from the snippet before it appeared in the
lilypond docs.

- Graham
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b