Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8120)

Issue 5900068: Implements relation-ids command

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by jimbaker
Modified:
12 years ago
Reviewers:
hazmat, mp+99150
Visibility:
Public.

Description

Implements relation-ids command. There are both API tests and usage in hooks. https://code.launchpad.net/~jimbaker/juju/relation-ids-command/+merge/99150 Requires: https://code.launchpad.net/~jimbaker/juju/relation-hook-context/+merge/99149 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : <please have a summary here> #

Total comments: 2

Patch Set 3 : <please have a summary here> #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -0 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A bin/relation-ids View 1 chunk +11 lines, -0 lines 0 comments Download
M juju/hooks/commands.py View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
M juju/hooks/protocol.py View 1 3 chunks +27 lines, -0 lines 0 comments Download
M juju/hooks/tests/test_communications.py View 1 4 chunks +20 lines, -0 lines 0 comments Download
M juju/hooks/tests/test_invoker.py View 1 2 2 chunks +54 lines, -0 lines 0 comments Download

Messages

Total messages: 8
jimbaker
Please take a look.
12 years, 1 month ago (2012-03-26 01:50:46 UTC) #1
jimbaker
Please take a look.
12 years, 1 month ago (2012-03-30 06:07:03 UTC) #2
hazmat
I'd like to see some more real testing beyond the mock implementations. https://codereview.appspot.com/5900068/diff/2001/juju/hooks/commands.py File juju/hooks/commands.py ...
12 years ago (2012-04-02 15:44:08 UTC) #3
jimbaker
Please take a look.
12 years ago (2012-04-05 01:17:38 UTC) #4
jimbaker
For some reason, it's now at https://codereview.appspot.com/5988043 after I tried updating the summary/description with lbox ...
12 years ago (2012-04-05 03:30:51 UTC) #5
jimbaker
I have added testing directly using the relation-ids command in hooks.
12 years ago (2012-04-05 03:33:19 UTC) #6
jimbaker
https://codereview.appspot.com/5900068/diff/2001/juju/hooks/commands.py File juju/hooks/commands.py (right): https://codereview.appspot.com/5900068/diff/2001/juju/hooks/commands.py#newcode95 juju/hooks/commands.py:95: default=os.environ.get("JUJU_RELATION"), The default of JUJU_RELATION is wrong and has ...
12 years ago (2012-04-05 03:33:28 UTC) #7
hazmat
12 years ago (2012-04-05 11:05:11 UTC) #8
looks good, +1
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b