Issue 58980043: p wishlist changed passing of whole list to only image object

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by prannoysircar0325

Modified:
10 years, 2 months ago

Reviewers:
mail2coolgarg

Base URL:
https://immpandroid.unfuddle.com/svn/immpandroid_android/

Visibility:
Public.

More Reviews

Description

p wishlist changed passing of whole list to only image object

Patch Set 1 #

Total comments: 6

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+400 lines, -63 lines)			Patch
M	pulltorefresh-and-loadmore/.classpath	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	shoppoke/AndroidManifest.xml	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A +	shoppoke/res/layout/header_layout.xml	View	1 chunk	+25 lines, -7 lines	1 comment	Download
M	shoppoke/res/values/arrays.xml	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	shoppoke/res/values/strings.xml	View	1 chunk	+1 line, -1 line	0 comments	Download
A	shoppoke/src/app/shoppoke/BaseSpDefaultFragment.java	View	1 chunk	+42 lines, -0 lines	0 comments	Download
M	shoppoke/src/app/shoppoke/storelist/BaseStoreListFragment.java	View	2 chunks	+4 lines, -3 lines	0 comments	Download
A	shoppoke/src/app/shoppoke/wishlist/WishDetailActivity.java	View	1 chunk	+33 lines, -0 lines	2 comments	Download
A	shoppoke/src/app/shoppoke/wishlist/WishListAdapter.java	View	1 chunk	+54 lines, -0 lines	0 comments	Download
A	shoppoke/src/app/shoppoke/wishlist/WishListFragment.java	View	1 chunk	+46 lines, -0 lines	2 comments	Download
A	spcore/res/layout/imagedetails.xml	View	1 chunk	+19 lines, -0 lines	0 comments	Download
A	spcore/res/layout/wish_list.xml	View	1 chunk	+19 lines, -0 lines	0 comments	Download
M	spcore/src/app/spcore/activities/dashboard/dashboard2/Dashboard2Activity.java	View	4 chunks	+18 lines, -14 lines	1 comment	Download
M	spcore/src/app/spcore/activities/message/ChatActivity.java	View	4 chunks	+31 lines, -25 lines	0 comments	Download
M	spcore/src/app/spcore/activities/photo/PhotoListner.java	View	5 chunks	+36 lines, -8 lines	0 comments	Download
M	spcore/src/app/spcore/activities/photo/PhotoObject.java	View	6 chunks	+57 lines, -1 line	0 comments	Download
M	spcore/src/app/spcore/base/BaseDefaultFragment.java	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	spcore/src/app/spcore/base/activities/BaseDefaultActivity.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	spcore/src/app/spcore/utils/Constants.java	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

mail2coolgarg

10 years, 2 months ago (2014-01-31 12:33:50 UTC) #1

fix the comments.

https://codereview.appspot.com/58980043/diff/1/shoppoke/res/layout/header_lay...
File shoppoke/res/layout/header_layout.xml (right):

https://codereview.appspot.com/58980043/diff/1/shoppoke/res/layout/header_lay...
shoppoke/res/layout/header_layout.xml:49:
android:background="@drawable/btn_cam_selector" />
make visibility gone by default. and make it feature protected in the code.

https://codereview.appspot.com/58980043/diff/1/shoppoke/src/app/shoppoke/wish...
File shoppoke/src/app/shoppoke/wishlist/WishDetailActivity.java (right):

https://codereview.appspot.com/58980043/diff/1/shoppoke/src/app/shoppoke/wish...
shoppoke/src/app/shoppoke/wishlist/WishDetailActivity.java:21: ImageView
imageview = (ImageView) findViewById(R.id.imagedetailwishlist);
SpImageLoadingListener.setImageView

https://codereview.appspot.com/58980043/diff/1/shoppoke/src/app/shoppoke/wish...
shoppoke/src/app/shoppoke/wishlist/WishDetailActivity.java:29: pObject =
getIntent().getExtras().getParcelable("PHOTO_OBJECT");
make it public static constant in SpConstant

https://codereview.appspot.com/58980043/diff/1/shoppoke/src/app/shoppoke/wish...
File shoppoke/src/app/shoppoke/wishlist/WishListFragment.java (right):

https://codereview.appspot.com/58980043/diff/1/shoppoke/src/app/shoppoke/wish...
shoppoke/src/app/shoppoke/wishlist/WishListFragment.java:26:
grid.setAdapter(listAdapter);// getResources()
remove this comment.

https://codereview.appspot.com/58980043/diff/1/shoppoke/src/app/shoppoke/wish...
shoppoke/src/app/shoppoke/wishlist/WishListFragment.java:43:
intent.putExtra("PHOTO_OBJECT", pObject);
declare this as constant.

https://codereview.appspot.com/58980043/diff/1/spcore/src/app/spcore/activiti...
File
spcore/src/app/spcore/activities/dashboard/dashboard2/Dashboard2Activity.java
(right):

https://codereview.appspot.com/58980043/diff/1/spcore/src/app/spcore/activiti...
spcore/src/app/spcore/activities/dashboard/dashboard2/Dashboard2Activity.java:18:
import app.spcore.activities.photo.PhotoListner;
revert this file.

Expand All Messages | Collapse All Messages