Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(341)

Issue 58940043: code review 58940043: freetype: add a Hinting enum in the top-level freetype ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by nigeltao
Modified:
10 years, 10 months ago
Reviewers:
bsiegert
CC:
bsiegert, golang-codereviews
Visibility:
Public.

Description

freetype: add a Hinting enum in the top-level freetype package, and hide the Hinter implementation in the freetype/truetype package.

Patch Set 1 #

Patch Set 2 : diff -r 9c2c96ee1dc1 https://code.google.com/p/freetype-go #

Patch Set 3 : diff -r 9c2c96ee1dc1 https://code.google.com/p/freetype-go #

Patch Set 4 : diff -r 9c2c96ee1dc1 https://code.google.com/p/freetype-go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -51 lines) Patch
M example/freetype/main.go View 1 2 chunks +7 lines, -0 lines 0 comments Download
M example/truetype/main.go View 1 1 chunk +1 line, -1 line 0 comments Download
M freetype/freetype.go View 1 5 chunks +26 lines, -4 lines 0 comments Download
M freetype/truetype/glyph.go View 1 11 chunks +30 lines, -18 lines 0 comments Download
M freetype/truetype/hint.go View 1 12 chunks +15 lines, -16 lines 0 comments Download
M freetype/truetype/hint_test.go View 1 2 chunks +3 lines, -3 lines 0 comments Download
M freetype/truetype/truetype_test.go View 1 5 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 4
nigeltao
Hello bsiegert@gmail.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/freetype-go
10 years, 10 months ago (2014-01-31 06:47:50 UTC) #1
nigeltao
Screenshot attached.
10 years, 10 months ago (2014-01-31 06:49:27 UTC) #2
bsiegert
LGTM although it is unfortunate that there is now a type Hinting (the constant) and ...
10 years, 10 months ago (2014-01-31 14:27:10 UTC) #3
nigeltao
10 years, 10 months ago (2014-02-01 03:13:00 UTC) #4
*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=4df03a627350 ***

freetype: add a Hinting enum in the top-level freetype package, and
hide the Hinter implementation in the freetype/truetype package.

LGTM=bsiegert
R=bsiegert
CC=golang-codereviews
https://codereview.appspot.com/58940043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b