Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(499)

Issue 5882053: Add an example implementation of cross-staff stems

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years ago by Pavel Roskin
Modified:
2 years ago
Reviewers:
Graham Percival, dak
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Add an example implementation of cross-staff stems

Patch Set 1 #

Patch Set 2 : Add an example implementation of cross-staff stems #

Total comments: 1

Patch Set 3 : Updated example with make-engraver, more comments and stripped Lilypond 2.14 compatibility code #

Patch Set 4 : Moving to snippets/new #

Patch Set 5 : Provide a more complete and readable example, update \version #

Patch Set 6 : Fix cross-staff beams, add a test case for them #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -0 lines) Patch
A Documentation/snippets/new/stem-cross-staff-engraver.ly View 1 2 3 4 5 1 chunk +166 lines, -0 lines 0 comments Download

Messages

Total messages: 7
Pavel Roskin
This is also the first use of a scheme engraver in input/regression.
2 years ago #1
dak
http://codereview.appspot.com/5882053/diff/2001/input/regression/stem-cross-staff-engraver.ly File input/regression/stem-cross-staff-engraver.ly (right): http://codereview.appspot.com/5882053/diff/2001/input/regression/stem-cross-staff-engraver.ly#newcode100 input/regression/stem-cross-staff-engraver.ly:100: `((acknowledgers Why don't you use make-engraver here? Instead of ...
2 years ago #2
dak
On 2012/03/23 13:04:19, Pavel Roskin wrote: > This is also the first use of a ...
2 years ago #3
Pavel Roskin
OK, I'll use make-engraver in the next revision. I guess I'll need to strip all ...
2 years ago #4
dak
On 2012/03/23 21:46:41, Pavel Roskin wrote: > OK, I'll use make-engraver in the next revision. ...
2 years ago #5
Graham Percival
The basic question is this: is this test helpful for programmers? At first glance I'd ...
2 years ago #6
Graham Percival
2 years ago #7
LGTM; since it's just a snippet now, I support pushing it directly as long as it
compiles.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5