Issue 5881043: adding new Google Analytics API samples

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5881043: adding new Google Analytics API samples (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by api.nickm1

Modified:
12 years, 1 month ago

Reviewers:
nm, chirags

Base URL:
http://google-api-php-client.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

code checked in here: http://code.google.com/p/google-api-php-client/source/detail?r=392

Patch Set 2 : fixed everything #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1396 lines, -0 lines)			Patch
A	examples/analytics/demo/authHelper.php	View	1	1 chunk	+126 lines, -0 lines	0 comments	Download
A	examples/analytics/demo/coreReportingApiReference.php	View		1 chunk	+317 lines, -0 lines	0 comments	Download
A	examples/analytics/demo/helloAnalyticsApi.php	View		1 chunk	+189 lines, -0 lines	0 comments	Download
A	examples/analytics/demo/index.php	View	1	1 chunk	+197 lines, -0 lines	0 comments	Download
A	examples/analytics/demo/managementApiReference.php	View		1 chunk	+483 lines, -0 lines	0 comments	Download
A	examples/analytics/demo/storage.php	View		1 chunk	+84 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

chirags

LGTM http://codereview.appspot.com/5881043/diff/1/examples/analytics/demo/authHelper.php File examples/analytics/demo/authHelper.php (right): http://codereview.appspot.com/5881043/diff/1/examples/analytics/demo/authHelper.php#newcode34 examples/analytics/demo/authHelper.php:34: private $controlerUrl; s/controler/controller http://codereview.appspot.com/5881043/diff/1/examples/analytics/demo/index.php File examples/analytics/demo/index.php (right): http://codereview.appspot.com/5881043/diff/1/examples/analytics/demo/index.php#newcode26 ...

12 years, 1 month ago (2012-03-23 17:50:20 UTC) #2

12 years, 1 month ago (2012-03-23 19:01:56 UTC) #3

fixed them.

http://codereview.appspot.com/5881043/diff/1/examples/analytics/demo/authHelp...
File examples/analytics/demo/authHelper.php (right):

http://codereview.appspot.com/5881043/diff/1/examples/analytics/demo/authHelp...
examples/analytics/demo/authHelper.php:34: private $controlerUrl;
On 2012/03/23 17:50:20, chirags wrote:
> s/controler/controller

Done.

http://codereview.appspot.com/5881043/diff/1/examples/analytics/demo/index.php
File examples/analytics/demo/index.php (right):

http://codereview.appspot.com/5881043/diff/1/examples/analytics/demo/index.ph...
examples/analytics/demo/index.php:26: *    
https://code.google.com/apis/console/b/0/
On 2012/03/23 17:50:20, chirags wrote:
> You can deep link into the api console to activate the analytics api:
> https://code.google.com/apis/console/?api=analytics

sweet

Expand All Messages | Collapse All Messages