Issue 5876070: rework arch/ec2-instance-type constraints

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5876070: rework arch/ec2-instance-type constraints

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by fwereade

Modified:
12 years, 1 month ago

Reviewers:
mp+99003

Visibility:
Public.

Description

rework arch/ec2-instance-type constraints Several linked changes: * arch constraint now has a default of "amd64" * arch constraint can be unset with the value "any" (0 makes no sense IMO) * cpu/mem can now also be unset with "any" for consistency * arch constraint no longer overlaps with ec2-instance-type * ec2-instance-type values now know if they need an hvm image * ec2 image/instance-type selection has been unified as get_machine_spec https://code.launchpad.net/~fwereade/juju/rework-arch-constraint/+merge/99003 Requires: https://code.launchpad.net/~fwereade/juju/accept-missing-constraints/+merge/98998 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : rework arch/ec2-instance-type constraints #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+160 lines, -130 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/agents/tests/test_provision.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	juju/control/tests/test_constraints_set.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	juju/control/tests/test_deploy.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	juju/machine/constraints.py	View	1	5 chunks	+32 lines, -27 lines	0 comments	Download
M	juju/machine/tests/test_constraints.py	View	1	7 chunks	+31 lines, -21 lines	0 comments	Download
M	juju/providers/ec2/launch.py	View		2 chunks	+5 lines, -6 lines	0 comments	Download
M	juju/providers/ec2/tests/common.py	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	juju/providers/ec2/tests/test_launch.py	View		3 chunks	+9 lines, -7 lines	0 comments	Download
M	juju/providers/ec2/tests/test_utils.py	View		9 chunks	+51 lines, -32 lines	0 comments	Download
M	juju/providers/ec2/utils.py	View		6 chunks	+24 lines, -32 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fwereade

12 years, 1 month ago (2012-03-26 09:06:20 UTC) #3

*** Submitted:

rework arch/ec2-instance-type constraints

Several linked changes:

* arch constraint now has a default of "amd64"
* arch constraint can be unset with the value "any" (0 makes no sense IMO)
* cpu/mem can now also be unset with "any" for consistency
* arch constraint no longer overlaps with ec2-instance-type
* ec2-instance-type values now know if they need an hvm image
* ec2 image/instance-type selection has been unified as get_machine_spec

R=hazmat
CC=
https://codereview.appspot.com/5876070

Expand All Messages | Collapse All Messages