environs/ec2: set admin-identity correctly in cloudinit.

environs/ec2: set admin-identity correctly in cloudinit.

This enables the cloud-init script to correctly start
juju-admin initialize.
The amazon test is now working again.

https://code.launchpad.net/~rogpeppe/juju/go-ec2-fix-admin-identity/+merge/98713

Requires: https://code.launchpad.net/~rogpeppe/juju/go-ec2-eventual-getfile/+merge/98662

(do not edit description out of merge proposal)

[rog, 2012-03-21 19:25:06]

Please take a look.

[niemeyer, 2012-03-21 20:45:53]

I'd like to understand why we need to support the admin secret setting. AFAIK,
this is a wishful thinking from our part (my part, mostly) that was never
actually used in practice. Can we go over that online quickly just so I can
understand the context?

[rog, 2012-03-22 10:04:47]

Please take a look.

[rog, 2012-03-22 10:06:13]

On 2012/03/21 20:45:53, niemeyer wrote:
> I'd like to understand why we need to support the admin secret setting. AFAIK,
> this is a wishful thinking from our part (my part, mostly) that was never
> actually used in practice. Can we go over that online quickly just so I can
> understand the context?

you're right, i was thinking that because a well-formed admin-identity  was
required, we'd need admin-secret in the config. but in fact we can just use a
constant admin-identity to jump through that hoop.

PTAL.

[rog, 2012-03-22 10:08:11]

On 2012/03/22 10:06:13, rog wrote:
> On 2012/03/21 20:45:53, niemeyer wrote:
> > I'd like to understand why we need to support the admin secret setting.
AFAIK,
> > this is a wishful thinking from our part (my part, mostly) that was never
> > actually used in practice. Can we go over that online quickly just so I can
> > understand the context?
> 
> you're right, i was thinking that because a well-formed admin-identity  was
> required, we'd need admin-secret in the config. but in fact we can just use a
> constant admin-identity to jump through that hoop.
> 
> PTAL.

eek, something nasty has gone wrong with the diffs, 
which are considerably *smaller* than they were!

[rog, 2012-03-22 14:21:29]

Please take a look.

[rog, 2012-03-22 14:32:49]

Please take a look.

[rog, 2012-03-22 15:48:42]

Please take a look.

[rog, 2012-03-22 17:29:09]

Please take a look.

[niemeyer, 2012-03-22 17:36:35]

LGTM

https://codereview.appspot.com/5868051/diff/8009/environs/ec2/auth.go
File environs/ec2/auth.go (right):

https://codereview.appspot.com/5868051/diff/8009/environs/ec2/auth.go#newcode13
environs/ec2/auth.go:13: // Given the name of a principle and a password,
makeIdentity
// makeIdentity transforms ...

[rog, 2012-03-22 17:40:39]

*** Submitted:

environs/ec2: set admin-identity correctly in cloudinit.

This enables the cloud-init script to correctly start
juju-admin initialize.
The amazon test is now working again.

R=niemeyer
CC=
https://codereview.appspot.com/5868051

https://codereview.appspot.com/5868051/diff/8009/environs/ec2/auth.go
File environs/ec2/auth.go (right):

https://codereview.appspot.com/5868051/diff/8009/environs/ec2/auth.go#newcode13
environs/ec2/auth.go:13: // Given the name of a principle and a password,
makeIdentity
On 2012/03/22 17:36:35, niemeyer wrote:
> // makeIdentity transforms ...

i generally prefer to start sentences with a capital letter when it's easy to do
so, but done anyway.

[niemeyer, 2012-03-22 17:45:40]

https://codereview.appspot.com/5868051/diff/8009/environs/ec2/auth.go
File environs/ec2/auth.go (right):

https://codereview.appspot.com/5868051/diff/8009/environs/ec2/auth.go#newcode13
environs/ec2/auth.go:13: // Given the name of a principle and a password,
makeIdentity
On 2012/03/22 17:40:39, rog wrote:
> On 2012/03/22 17:36:35, niemeyer wrote:
> > // makeIdentity transforms ...
> 
> i generally prefer to start sentences with a capital

The standard Go convention is very clear in which function documentation starts
with the name of the function.

[rog, 2012-03-22 19:06:33]

On 22 March 2012 17:45,  <n13m3y3r@gmail.com> wrote:
>
> https://codereview.appspot.com/5868051/diff/8009/environs/ec2/auth.go
> File environs/ec2/auth.go (right):
>
>
https://codereview.appspot.com/5868051/diff/8009/environs/ec2/auth.go#newcode13
> environs/ec2/auth.go:13: // Given the name of a principle and a
> password, makeIdentity
> On 2012/03/22 17:40:39, rog wrote:
>>
>> On 2012/03/22 17:36:35, niemeyer wrote:
>> > // makeIdentity transforms ...
>
>
>> i generally prefer to start sentences with a capital
>
>
> The standard Go convention is very clear in which function documentation
> starts with the name of the function.

I was aware they had to be complete sentences, but I wasn't
aware that the function name always had to come first,
although as you say, it's stated quite clearly in Effective Go.

I'd remembered this remark of Brad's:

http://codereview.appspot.com/5653067/diff/3001/openpgp/keys.go#newcode383

but hadn't realised that it wasn't referring to the first sentence
of the doc comment.

I shall be aware in future :-)