Issue 58680043: Minor fixes to code comments and documentation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 58680043: Minor fixes to code comments and documentation

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by frankban

Modified:
10 years, 3 months ago

Reviewers:
mp+203942, bac

Visibility:
Public.

Description

Minor fixes to code comments and documentation Also fixed a possible encoding problem in error handling. The get_admin_secret function and its test case are just moved, no need to re-review. Tests: `make check`. No QA. https://code.launchpad.net/~frankban/juju-quickstart/minor-fixes-0/+merge/203942 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Minor fixes to code comments and documentation #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -48 lines)			Patch
M	HACKING.rst	View	1 chunk	+8 lines, -0 lines	0 comments	Download
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	quickstart/app.py	View	2 chunks	+22 lines, -22 lines	0 comments	Download
M	quickstart/manage.py	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	quickstart/tests/test_app.py	View	2 chunks	+20 lines, -20 lines	0 comments	Download
M	quickstart/tests/test_manage.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

frankban

10 years, 3 months ago (2014-01-30 13:24:19 UTC) #3

*** Submitted:

Minor fixes to code comments and documentation

Also fixed a possible encoding problem in error handling.

The get_admin_secret function and its test case are just moved, no
need to re-review. 

Tests: `make check`.
No QA.

R=bac
CC=
https://codereview.appspot.com/58680043

Expand All Messages | Collapse All Messages