environs/ec2: use local images data for local tests

environs/ec2: use local images data for local tests



https://code.launchpad.net/~rogpeppe/juju/go-ec2-local-images/+merge/98601

(do not edit description out of merge proposal)

[rog, 2012-03-21 10:42:09]

Please take a look.

[rog, 2012-03-21 11:03:58]

Please take a look.

[niemeyer, 2012-03-21 15:47:42]

LGTM

https://codereview.appspot.com/5866049/diff/3001/environs/ec2/export_test.go
File environs/ec2/export_test.go (right):

https://codereview.appspot.com/5866049/diff/3001/environs/ec2/export_test.go#...
environs/ec2/export_test.go:48: func UseLocalImages(local bool) {
Can we please have s/UseLocalImages/UseTestImageData/, so it becomes more clear
when reading the tests that this is a hack rather than a proper API of the ec2
package, and also that it's the data that is being affected (not the actual
images)?

https://codereview.appspot.com/5866049/diff/3001/environs/ec2/image.go
File environs/ec2/image.go (right):

https://codereview.appspot.com/5866049/diff/3001/environs/ec2/image.go#newcode34
environs/ec2/image.go:34: // imageURL holds the address of the images http
server.
s/imageURL/imagesHost/

[rog, 2012-03-21 16:04:04]

Please take a look.

https://codereview.appspot.com/5866049/diff/3001/environs/ec2/export_test.go
File environs/ec2/export_test.go (right):

https://codereview.appspot.com/5866049/diff/3001/environs/ec2/export_test.go#...
environs/ec2/export_test.go:48: func UseLocalImages(local bool) {
On 2012/03/21 15:47:42, niemeyer wrote:
> Can we please have s/UseLocalImages/UseTestImageData/, so it becomes more
clear
> when reading the tests that this is a hack rather than a proper API of the ec2
> package, and also that it's the data that is being affected (not the actual
> images)?

Done.

https://codereview.appspot.com/5866049/diff/3001/environs/ec2/export_test.go#...
environs/ec2/export_test.go:48: func UseLocalImages(local bool) {
On 2012/03/21 15:47:42, niemeyer wrote:
> Can we please have s/UseLocalImages/UseTestImageData/, so it becomes more
clear
> when reading the tests that this is a hack rather than a proper API of the ec2
> package, and also that it's the data that is being affected (not the actual
> images)?

Done.

[rog, 2012-03-21 16:05:47]

*** Submitted:

environs/ec2: use local images data for local tests

R=niemeyer
CC=
https://codereview.appspot.com/5866049