Issue 5864047: environs/ec2: add juju-origin to configuration.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5864047: environs/ec2: add juju-origin to configuration.

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by rog

Modified:
12 years, 1 month ago

Reviewers:
mp+98615

Visibility:
Public.

Description

environs/ec2: add juju-origin to configuration. https://code.launchpad.net/~rogpeppe/juju/ec2-add-juju-origin/+merge/98615 Requires: https://code.launchpad.net/~rogpeppe/juju/go-ec2-local-images/+merge/98601 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : environs/ec2: add juju-origin to configuration. #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -3 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/ec2/cloudinit.go	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	environs/ec2/config.go	View	1	4 chunks	+11 lines, -2 lines	0 comments	Download
M	environs/ec2/config_test.go	View		1 chunk	+26 lines, -0 lines	0 comments	Download
M	environs/ec2/ec2.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	environs/ec2/live_test.go	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	environs/ec2/local_test.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

LGTM, nice. https://codereview.appspot.com/5864047/diff/1/environs/ec2/cloudinit_test.go File environs/ec2/cloudinit_test.go (right): https://codereview.appspot.com/5864047/diff/1/environs/ec2/cloudinit_test.go#newcode63 environs/ec2/cloudinit_test.go:63: ? https://codereview.appspot.com/5864047/diff/1/environs/ec2/config.go File environs/ec2/config.go (right): https://codereview.appspot.com/5864047/diff/1/environs/ec2/config.go#newcode17 environs/ec2/config.go:17: ...

12 years, 1 month ago (2012-03-21 20:30:43 UTC) #2

rog

12 years, 1 month ago (2012-03-22 09:45:52 UTC) #4

*** Submitted:

environs/ec2: add juju-origin to configuration.

R=niemeyer
CC=
https://codereview.appspot.com/5864047

https://codereview.appspot.com/5864047/diff/1/environs/ec2/cloudinit_test.go
File environs/ec2/cloudinit_test.go (right):

https://codereview.appspot.com/5864047/diff/1/environs/ec2/cloudinit_test.go#...
environs/ec2/cloudinit_test.go:63: 
On 2012/03/21 20:30:43, niemeyer wrote:
> ?

Done.

https://codereview.appspot.com/5864047/diff/1/environs/ec2/config.go
File environs/ec2/config.go (right):

https://codereview.appspot.com/5864047/diff/1/environs/ec2/config.go#newcode17
environs/ec2/config.go:17: origin jujuOrigin
On 2012/03/21 20:30:43, niemeyer wrote:
> gofmt

Done.

Expand All Messages | Collapse All Messages