Issue 58630043: code review 58630043: googleapi: try to hit EOF after decoding JSON response,...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 58630043: code review 58630043: googleapi: try to hit EOF after decoding JSON response,... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by bradfitz

Modified:
11 years, 7 months ago

Reviewers:
adg

CC:
adg, golang-codereviews

Visibility:
Public.

Description

googleapi: try to hit EOF after decoding JSON response, before Close Makes it more likely we'll reuse connections.

Patch Set 1 #

Patch Set 2 : diff -r 2f3a11c87522 https://code.google.com/p/google-api-go-client/ #

Patch Set 3 : diff -r 2f3a11c87522 https://code.google.com/p/google-api-go-client/ #

Patch Set 4 : diff -r 96de9192b410 https://code.google.com/p/google-api-go-client/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -1 line)			Patch
	M	google-api-go-generator/gen.go	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
	M	googleapi/googleapi.go	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/google-api-go-client/

11 years, 7 months ago (2014-01-30 10:05:32 UTC) #1

bradfitz

11 years, 7 months ago (2014-01-30 10:11:12 UTC) #3

*** Submitted as
https://code.google.com/p/google-api-go-client/source/detail?r=be3a8d2fdcd8 ***

googleapi: try to hit EOF after decoding JSON response, before Close

Makes it more likely we'll reuse connections.

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/58630043

Expand All Messages | Collapse All Messages