R=adg,dsymonds
PTAL. Merged recent changes to main.go into appinit.go
http://codereview.appspot.com/5849053/diff/9001/src/cmd/godoc/README.godoc-app File src/cmd/godoc/README.godoc-app (right): http://codereview.appspot.com/5849053/diff/9001/src/cmd/godoc/README.godoc-ap... src/cmd/godoc/README.godoc-app:11: * Go appengine SDK go1beta4 - 2012-03-14 just change this to "Go App Engine SDK" - the go1 part will become the default shortly. http://codereview.appspot.com/5849053/diff/9001/src/cmd/godoc/README.godoc-ap... src/cmd/godoc/README.godoc-app:12: http://code.google.com/p/appengine-go/downloads/list https://developers.google.com/appengine/downloads http://codereview.appspot.com/5849053/diff/9001/src/cmd/godoc/README.godoc-ap... src/cmd/godoc/README.godoc-app:37: api_version: go1beta go1 http://codereview.appspot.com/5849053/diff/9001/src/cmd/godoc/README.godoc-ap... src/cmd/godoc/README.godoc-app:47: - main.go is excluded (appinit.go is taking its place) add "// +build !appengine" to main.go and we can remove this line
PTAL, all done. On Tue, Mar 27, 2012 at 7:20 AM, <adg@golang.org> wrote: > > http://codereview.appspot.com/**5849053/diff/9001/src/cmd/** > godoc/README.godoc-app<http://codereview.appspot.com/5849053/diff/9001/src/cmd/godoc/README.godoc-app> > File src/cmd/godoc/README.godoc-app (right): > > http://codereview.appspot.com/**5849053/diff/9001/src/cmd/** > godoc/README.godoc-app#**newcode11<http://codereview.appspot.com/5849053/diff/9001/src/cmd/godoc/README.godoc-app#newcode11> > src/cmd/godoc/README.godoc-**app:11: * Go appengine SDK go1beta4 - > 2012-03-14 > just change this to "Go App Engine SDK" - the go1 part will become the > default shortly. > > http://codereview.appspot.com/**5849053/diff/9001/src/cmd/** > godoc/README.godoc-app#**newcode12<http://codereview.appspot.com/5849053/diff/9001/src/cmd/godoc/README.godoc-app#newcode12> > src/cmd/godoc/README.godoc-**app:12: > http://code.google.com/p/**appengine-go/downloads/list<http://code.google.com... > https://developers.google.com/**appengine/downloads<https://developers.google... > > http://codereview.appspot.com/**5849053/diff/9001/src/cmd/** > godoc/README.godoc-app#**newcode37<http://codereview.appspot.com/5849053/diff/9001/src/cmd/godoc/README.godoc-app#newcode37> > src/cmd/godoc/README.godoc-**app:37: api_version: go1beta > go1 > > http://codereview.appspot.com/**5849053/diff/9001/src/cmd/** > godoc/README.godoc-app#**newcode47<http://codereview.appspot.com/5849053/diff/9001/src/cmd/godoc/README.godoc-app#newcode47> > src/cmd/godoc/README.godoc-**app:47: - main.go is excluded (appinit.go is > taking its place) > add "// +build !appengine" to main.go and we can remove this line > > http://codereview.appspot.com/**5849053/<http://codereview.appspot.com/5849053/> >
ping? (Due to a Rietveld bug, I can't 'hg mail' this CL)
LGTM
Hello adg@golang.org, dsymonds@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
*** Submitted as http://code.google.com/p/go/source/detail?r=f68d1d478a97 *** cmd/godoc: update App Engine README and script for Go 1 R=adg, dsymonds CC=golang-dev http://codereview.appspot.com/5849053