Add option to disable apt in ProvisioningScript

Add option to disable apt in ProvisioningScript

The ProvisioningScript API is updated to take a
boolean option DisablePackageCommands to completely
disable all package-related commands (apt-get, etc.)
This is for the benefit of external provisioners
that require more control over which packages are
installed and from where.

https://code.launchpad.net/~axwalk/juju-core/provisioningscript-api-disableaptcommands/+merge/203866

(do not edit description out of merge proposal)

[axw, 2014-01-30 02:32:37]

Please take a look.

[wallyworld, 2014-01-30 03:07:09]

LGTM with a test tweak

https://codereview.appspot.com/58490043/diff/1/state/apiserver/client/client_...
File state/apiserver/client/client_test.go (right):

https://codereview.appspot.com/58490043/diff/1/state/apiserver/client/client_...
state/apiserver/client/client_test.go:1718: c.Assert(script,
gc.Not(jc.Contains), "apt-get")
Please add the opposite check to the test above this one to ensure apt-get still
gets inserted in the script when DisablePackageCommands is false

[axw, 2014-01-30 03:38:13]

Please take a look.

https://codereview.appspot.com/58490043/diff/1/state/apiserver/client/client_...
File state/apiserver/client/client_test.go (right):

https://codereview.appspot.com/58490043/diff/1/state/apiserver/client/client_...
state/apiserver/client/client_test.go:1718: c.Assert(script,
gc.Not(jc.Contains), "apt-get")
On 2014/01/30 03:07:10, wallyworld wrote:
> Please add the opposite check to the test above this one to ensure apt-get
still
> gets inserted in the script when DisablePackageCommands is false

Done. I'd rather test the option separately, so I just modified this test to
range over []bool{false, true} and alter the checker accordingly.