Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(121)

Issue 58480045: code review 58480045: cmd/go: skip $ORIGIN test on darwin systems (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 8 months ago by dfc
Modified:
5 years, 8 months ago
Reviewers:
iant
CC:
iant, golang-codereviews
Visibility:
Public.

Description

cmd/go: skip $ORIGIN test on darwin systems Fixes issue 7293. Update issue 7261 The bsd ld(1) does not understand $ORIGIN and has restrictions on using -rpath when using clang(1), the default compiler on darwin.

Patch Set 1 #

Patch Set 2 : diff -r b1f7a2f34d33 https://code.google.com/p/go #

Patch Set 3 : diff -r b1f7a2f34d33 https://code.google.com/p/go #

Patch Set 4 : diff -r b1f7a2f34d33 https://code.google.com/p/go #

Patch Set 5 : diff -r b1f7a2f34d33 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
src/cmd/go/test.bash View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
dfc
Hello iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
5 years, 8 months ago (2014-02-10 00:58:47 UTC) #1
iant
LGTM
5 years, 8 months ago (2014-02-10 02:05:49 UTC) #2
dfc
5 years, 8 months ago (2014-02-10 02:35:56 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=028678d23c22 ***

cmd/go: skip $ORIGIN test on darwin systems

Fixes issue 7293.

Update issue 7261

The bsd ld(1) does not understand $ORIGIN and has restrictions on using -rpath
when using clang(1), the default compiler on darwin.

LGTM=iant
R=iant
CC=golang-codereviews
https://codereview.appspot.com/58480045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b