Issue 5845072: Improved status output

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5845072: Improved status output

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by hazmat

Modified:
12 years, 1 month ago

Reviewers:
mp+98322, fwereade

Visibility:
Public.

Description

Improved status output Per the spec/list discussion this branch - display unit error states hyphenated - use unique lists for services of any named relation - display only relation errors at a unit level https://code.launchpad.net/~hazmat/juju/status-changes/+merge/98322 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+240 lines, -130 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	juju/charm/tests/repository/series/funkyblog/config.yaml	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A	juju/charm/tests/repository/series/funkyblog/metadata.yaml	View	1 chunk	+17 lines, -0 lines	0 comments	Download
A	juju/charm/tests/repository/series/funkyblog/revision	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	juju/control/status.py	View	7 chunks	+60 lines, -45 lines	0 comments	Download
M	juju/control/tests/test_status.py	View	13 chunks	+153 lines, -82 lines	1 comment	Download
M	juju/state/tests/test_service.py	View	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

fwereade

12 years, 1 month ago (2012-03-22 18:08:56 UTC) #2

LGTM

https://codereview.appspot.com/5845072/diff/1/juju/control/tests/test_status.py
File juju/control/tests/test_status.py (right):

https://codereview.appspot.com/5845072/diff/1/juju/control/tests/test_status....
juju/control/tests/test_status.py:229: def add_provider_machine(self):
yay, nice :)

Expand All Messages | Collapse All Messages