Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13370)

Issue 5845059: code review 5845059: doc: various typos, remove apostrophes from ordinals

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by jnj
Modified:
12 years, 1 month ago
Reviewers:
r
CC:
golang-dev, r, r2
Visibility:
Public.

Description

doc: various typos, remove apostrophes from ordinals

Patch Set 1 #

Patch Set 2 : diff -r c8614af8523a https://code.google.com/p/go/ #

Patch Set 3 : diff -r 047d46024b74 https://code.google.com/p/go/ #

Total comments: 5

Patch Set 4 : diff -r b15d9965bcd8 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 14c7fd2498d6 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 14c7fd2498d6 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M doc/code.html View 1 1 chunk +1 line, -1 line 0 comments Download
M doc/debugging_with_gdb.html View 1 1 chunk +1 line, -1 line 0 comments Download
M doc/gccgo_install.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M doc/go_mem.html View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M doc/go_spec.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11
jnj
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
12 years, 1 month ago (2012-03-17 08:36:46 UTC) #1
r
http://codereview.appspot.com/5845059/diff/4001/doc/gccgo_install.html File doc/gccgo_install.html (right): http://codereview.appspot.com/5845059/diff/4001/doc/gccgo_install.html#newcode345 doc/gccgo_install.html:345: The C function naturally expects a null terminated string, ...
12 years, 1 month ago (2012-03-17 09:21:28 UTC) #2
jnj
http://codereview.appspot.com/5845059/diff/4001/doc/go_mem.html File doc/go_mem.html (right): http://codereview.appspot.com/5845059/diff/4001/doc/go_mem.html#newcode286 doc/go_mem.html:286: the <i>n</i>th call to <code>l.Unlock()</code> happens before the <i>m</i>th ...
12 years, 1 month ago (2012-03-17 09:45:35 UTC) #3
r2
On 17/03/2012, at 8:45 PM, jeremyjackins@gmail.com wrote: > > http://codereview.appspot.com/5845059/diff/4001/doc/go_mem.html > File doc/go_mem.html (right): > ...
12 years, 1 month ago (2012-03-17 09:52:44 UTC) #4
jnj
http://codereview.appspot.com/5845059/diff/4001/doc/gccgo_install.html File doc/gccgo_install.html (right): http://codereview.appspot.com/5845059/diff/4001/doc/gccgo_install.html#newcode345 doc/gccgo_install.html:345: The C function naturally expects a null terminated string, ...
12 years, 1 month ago (2012-03-17 20:04:38 UTC) #5
jnj
Hello golang-dev@googlegroups.com, r@golang.org, r@google.com (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 1 month ago (2012-03-17 20:05:09 UTC) #6
r
You didn't rewrite go_mem.html as suggested.
12 years, 1 month ago (2012-03-18 00:45:25 UTC) #7
jnj
On 2012/03/18 00:45:25, r wrote: > You didn't rewrite go_mem.html as suggested. Sorry, I misread ...
12 years, 1 month ago (2012-03-18 19:43:48 UTC) #8
jnj
Hello golang-dev@googlegroups.com, r@golang.org, r@google.com (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 1 month ago (2012-03-18 19:45:35 UTC) #9
r
LGTM thanks
12 years, 1 month ago (2012-03-18 21:26:15 UTC) #10
r
12 years, 1 month ago (2012-03-18 21:26:42 UTC) #11
*** Submitted as http://code.google.com/p/go/source/detail?r=0a5692d60e01 ***

doc: various typos, remove apostrophes from ordinals

R=golang-dev, r, r
CC=golang-dev
http://codereview.appspot.com/5845059

Committer: Rob Pike <r@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b