Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(243)

Issue 5845045: presence, state: fix zookeeper error checks for new zookeeper error type.

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by rog
Modified:
12 years, 1 month ago
Reviewers:
mp+97835
Visibility:
Public.

Description

https://code.launchpad.net/~rogpeppe/juju/go-zookeeper-error-change/+merge/97835 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : presence, state: fix zookeeper error checks for new zookeeper error type. #

Patch Set 3 : presence, state: fix zookeeper error checks for new zookeeper error type. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -15 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M state/presence/presence.go View 3 chunks +4 lines, -4 lines 0 comments Download
M state/service.go View 2 chunks +2 lines, -2 lines 0 comments Download
M state/state.go View 1 chunk +1 line, -1 line 0 comments Download
M state/topology.go View 1 chunk +1 line, -1 line 0 comments Download
M state/unit.go View 6 chunks +6 lines, -6 lines 0 comments Download
M state/util.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
rog
Please take a look.
12 years, 1 month ago (2012-03-16 10:47:02 UTC) #1
fwereade
LGTM, assuming gozk is in and tagged :).
12 years, 1 month ago (2012-03-16 11:18:51 UTC) #2
rog
12 years, 1 month ago (2012-03-16 12:46:55 UTC) #3
*** Submitted:

presence, state: fix zookeeper error checks for new zookeeper error type.

R=fwereade
CC=
https://codereview.appspot.com/5845045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b