Adding of WaitAlive() to presence package.

Adding of WaitAlive() to presence package.

WaitAlive() allows to wait until a node is created by a
pinger or timeout occurs.

https://code.launchpad.net/~themue/juju/go-presence-wait-alive/+merge/98369

(do not edit description out of merge proposal)

[TheMue, 2012-03-20 09:31:01]

Please take a look.

[TheMue, 2012-03-20 14:22:48]

Please take a look.

[niemeyer, 2012-03-20 15:09:07]

https://codereview.appspot.com/5843068/diff/1001/state/presence/presence.go
File state/presence/presence.go (right):

https://codereview.appspot.com/5843068/diff/1001/state/presence/presence.go#n...
state/presence/presence.go:245: // WaitAlive blocks until the Pinger at the
given path is alive.
// WaitAlive blocks until the node at the given path
// has been recently pinged.

https://codereview.appspot.com/5843068/diff/1001/state/presence/presence.go#n...
state/presence/presence.go:266: func WaitAliveTimeout(conn *zk.Conn, path
string, timeout time.Duration) error {
Please drop this function if we don't need it now. We can join this logic in
WaitAlive itself, if we ever need it.

https://codereview.appspot.com/5843068/diff/1001/state/presence/presence_test.go
File state/presence/presence_test.go (right):

https://codereview.appspot.com/5843068/diff/1001/state/presence/presence_test...
state/presence/presence_test.go:294: func (s *PresenceSuite)
TestWaitAliveTimeout(c *C) {
Where's the test for WaitAlive?

[TheMue, 2012-03-20 16:05:17]

Please take a look.

https://codereview.appspot.com/5843068/diff/1001/state/presence/presence.go
File state/presence/presence.go (right):

https://codereview.appspot.com/5843068/diff/1001/state/presence/presence.go#n...
state/presence/presence.go:245: // WaitAlive blocks until the Pinger at the
given path is alive.
On 2012/03/20 15:09:08, niemeyer wrote:
> // WaitAlive blocks until the node at the given path
> // has been recently pinged.

Done.

https://codereview.appspot.com/5843068/diff/1001/state/presence/presence.go#n...
state/presence/presence.go:266: func WaitAliveTimeout(conn *zk.Conn, path
string, timeout time.Duration) error {
On 2012/03/20 15:09:08, niemeyer wrote:
> Please drop this function if we don't need it now. We can join this logic in
> WaitAlive itself, if we ever need it.

Done by migration back into WaitAlive().

https://codereview.appspot.com/5843068/diff/1001/state/presence/presence_test.go
File state/presence/presence_test.go (right):

https://codereview.appspot.com/5843068/diff/1001/state/presence/presence_test...
state/presence/presence_test.go:294: func (s *PresenceSuite)
TestWaitAliveTimeout(c *C) {
On 2012/03/20 15:09:08, niemeyer wrote:
> Where's the test for WaitAlive?

Done.

[niemeyer, 2012-03-20 17:14:48]

LGTM, thanks!

[TheMue, 2012-03-20 20:13:58]

*** Submitted:

Adding of WaitAlive() to presence package.

WaitAlive() allows to wait until a node is created by a
pinger or timeout occurs.

R=niemeyer
CC=
https://codereview.appspot.com/5843068