environs/ec2: hook juju logging up to gocheck test logging.

environs/ec2: hook juju logging up to gocheck test logging.



https://code.launchpad.net/~rogpeppe/juju/go-ec2-improved-logging/+merge/98210

(do not edit description out of merge proposal)

[rog, 2012-03-19 14:44:36]

Please take a look.

[niemeyer, 2012-03-19 15:48:37]

LGTM, but the messages need some love.

https://codereview.appspot.com/5841067/diff/1001/environs/ec2/ec2.go
File environs/ec2/ec2.go (right):

https://codereview.appspot.com/5841067/diff/1001/environs/ec2/ec2.go#newcode96
environs/ec2/ec2.go:96: log.Printf("environs/ec2: Open %q", name)
This is oriented towards a log file that will be read by users, and thus has to
be worded to be readable by them. It's fine to keep a prefix, I guess, but it
has to be at least human-oriented. For example:

    "environs/ec2: opening environment %q"

https://codereview.appspot.com/5841067/diff/1001/environs/ec2/ec2.go#newcode110
environs/ec2/ec2.go:110: log.Printf("environs/ec2: Bootstrap %q", e.name)
"environs/ec2: bootstrapping environment %q"

https://codereview.appspot.com/5841067/diff/1001/environs/ec2/ec2.go#newcode170
environs/ec2/ec2.go:170: log.Printf("environs/ec2: StartInstance %q, machine
%d", e.name, machineId)
"environs/ec2: starting machine %d in environment %q"

https://codereview.appspot.com/5841067/diff/1001/environs/ec2/ec2.go#newcode323
environs/ec2/ec2.go:323: log.Printf("environs/ec2: Destroy %s", e.name)
"environs/ec2: destroying environment %q"

[rog, 2012-03-19 17:18:24]

Please take a look.

https://codereview.appspot.com/5841067/diff/1001/environs/ec2/ec2.go
File environs/ec2/ec2.go (right):

https://codereview.appspot.com/5841067/diff/1001/environs/ec2/ec2.go#newcode96
environs/ec2/ec2.go:96: log.Printf("environs/ec2: Open %q", name)
On 2012/03/19 15:48:38, niemeyer wrote:
> This is oriented towards a log file that will be read by users, and thus has
to
> be worded to be readable by them. It's fine to keep a prefix, I guess, but it
> has to be at least human-oriented. For example:
> 
>     "environs/ec2: opening environment %q"

Done.

https://codereview.appspot.com/5841067/diff/1001/environs/ec2/ec2.go#newcode110
environs/ec2/ec2.go:110: log.Printf("environs/ec2: Bootstrap %q", e.name)
On 2012/03/19 15:48:38, niemeyer wrote:
> "environs/ec2: bootstrapping environment %q"

Done.

https://codereview.appspot.com/5841067/diff/1001/environs/ec2/ec2.go#newcode170
environs/ec2/ec2.go:170: log.Printf("environs/ec2: StartInstance %q, machine
%d", e.name, machineId)
On 2012/03/19 15:48:38, niemeyer wrote:
> "environs/ec2: starting machine %d in environment %q"

Done.

https://codereview.appspot.com/5841067/diff/1001/environs/ec2/ec2.go#newcode323
environs/ec2/ec2.go:323: log.Printf("environs/ec2: Destroy %s", e.name)
On 2012/03/19 15:48:38, niemeyer wrote:
> "environs/ec2: destroying environment %q"

Done.

[rog, 2012-03-19 17:20:52]

*** Submitted:

environs/ec2: hook juju logging up to gocheck test logging.

R=niemeyer
CC=
https://codereview.appspot.com/5841067