Issue 5841056: Charm local repositories should always process all their charms for a search.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5841056: Charm local repositories should always process all their charms for a search.

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by hazmat

Modified:
12 years, 1 month ago

Reviewers:
mp+98062, fwereade

Visibility:
Public.

Description

Charm local repositories should always process all their charms for a search. Changes - add catch all handler to repository for unexpected errors (os) - rearrange charm exception hierarchy - charmnotfound is not a charm structural error - metadata errors are charm errors. https://code.launchpad.net/~hazmat/juju/repository-broken-charms/+merge/98062 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -42 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/charm/errors.py	View	2 chunks	+22 lines, -13 lines	1 comment	Download
M	juju/charm/repository.py	View	2 chunks	+9 lines, -4 lines	0 comments	Download
M	juju/charm/tests/test_errors.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	juju/charm/tests/test_repository.py	View	8 chunks	+42 lines, -24 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

fwereade

12 years, 1 month ago (2012-03-23 14:21:20 UTC) #2

LGTM

https://codereview.appspot.com/5841056/diff/1/juju/charm/errors.py
File juju/charm/errors.py (right):

https://codereview.appspot.com/5841056/diff/1/juju/charm/errors.py#newcode30
juju/charm/errors.py:30: """Raised when an error in the info file of a charm is
found."""
MetaDataError seems to be missing a test; might be worth adding one, however
trivial it may be; and it also appears to have no methods that need to exist.

Expand All Messages | Collapse All Messages