Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1464)

Issue 583590043: output-distance: treat non-existent files as empty string (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by hanwenn
Modified:
4 months ago
Reviewers:
Dan Eble, hahnjo
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

output-distance: treat non-existent files as empty string This avoids callings strip() on None

Patch Set 1 #

Patch Set 2 : Dan comment #

Total comments: 2

Patch Set 3 : reword comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M scripts/build/output-distance.py View 1 2 5 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 13
hahnjo
LGTM
4 months, 1 week ago (2020-02-28 17:34:20 UTC) #1
Dan Eble
This does not look good. I expect this change to break the feature I added ...
4 months, 1 week ago (2020-02-28 23:31:17 UTC) #2
Dan Eble
On 2020/02/28 23:31:17, Dan Eble wrote: > This does not look good. I expect this ...
4 months, 1 week ago (2020-02-28 23:33:32 UTC) #3
hanwenn
On 2020/02/28 23:33:32, Dan Eble wrote: > On 2020/02/28 23:31:17, Dan Eble wrote: > > ...
4 months, 1 week ago (2020-02-29 12:49:11 UTC) #4
hanwenn
Dan comment
4 months, 1 week ago (2020-02-29 12:51:30 UTC) #5
Dan Eble
https://codereview.appspot.com/583590043/diff/571790043/scripts/build/output-distance.py File scripts/build/output-distance.py (right): https://codereview.appspot.com/583590043/diff/571790043/scripts/build/output-distance.py#newcode531 scripts/build/output-distance.py:531: if self.contents[0] is None != self.contents[1] is None: This ...
4 months, 1 week ago (2020-02-29 15:51:44 UTC) #6
hanwenn
reword comment
4 months, 1 week ago (2020-03-05 10:29:35 UTC) #7
hanwenn
https://codereview.appspot.com/583590043/diff/571790043/scripts/build/output-distance.py File scripts/build/output-distance.py (right): https://codereview.appspot.com/583590043/diff/571790043/scripts/build/output-distance.py#newcode531 scripts/build/output-distance.py:531: if self.contents[0] is None != self.contents[1] is None: On ...
4 months, 1 week ago (2020-03-05 10:33:57 UTC) #8
Dan Eble
On 2020/03/05 10:33:57, hanwenn wrote: > > the script fail on None.strip(), though not the ...
4 months, 1 week ago (2020-03-06 01:03:49 UTC) #9
hanwenn
On 2020/03/06 01:03:49, Dan Eble wrote: > On 2020/03/05 10:33:57, hanwenn wrote: > > > ...
4 months ago (2020-03-06 16:28:01 UTC) #10
hanwenn
(https://github.com/hanwen/lilypond/pull/2 as a PR)
4 months ago (2020-03-06 16:47:49 UTC) #11
Dan Eble
On 2020/03/06 16:28:01, hanwenn wrote: > > https://codereview.appspot.com/581770043/diff/561510043/scripts/build/output-distance.py > > it leaves striped cells for ...
4 months ago (2020-03-07 01:02:48 UTC) #12
hanwenn
4 months ago (2020-03-07 09:33:27 UTC) #13
abandoning for 5824
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b