Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7549)

Issue 583550043: Remove redundant checks with C++11 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by hahnjo
Modified:
3 years, 11 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Remove redundant checks with C++11 Individual changes: 1) Drop check for std::vector::data() The corresponding code was already removed in 2015, commit d36ec1303b ("Issue 4577: Remove the nasty workaround for platforms that don't provide std::vector::data()."). 2) flower: Rely on [v]snprintf from libc These are required in C++11 according to https://en.cppreference.com/w/cpp/io/c/fprintf https://en.cppreference.com/w/cpp/io/c/vfprintf While editing config.hh.in, also get rid of unused HAVE_LRINT. 3) Drop check for explicit template instantiation The define was unused and as far as I can tell, the code is valid C++ and should just always work.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -107 lines) Patch
M aclocal.m4 View 2 chunks +0 lines, -43 lines 0 comments Download
M config.hh.in View 2 chunks +0 lines, -18 lines 0 comments Download
M configure.ac View 2 chunks +1 line, -3 lines 0 comments Download
M flower/include/libc-extension.hh View 1 chunk +0 lines, -13 lines 0 comments Download
M flower/include/std-vector.hh View 1 chunk +0 lines, -1 line 0 comments Download
M flower/libc-extension.cc View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 1
lemzwerg
4 years, 1 month ago (2020-02-20 15:21:39 UTC) #1
Very nice, thanks!  LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b