Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 5835045: zookeeper: make error messages more informative.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by rog
Modified:
9 years, 10 months ago
Reviewers:
mp+97613
Visibility:
Public.

Description

https://code.launchpad.net/~rogpeppe/gozk/better-error-messages/+merge/97613 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : zookeeper: make error messages more informative. #

Total comments: 11

Patch Set 3 : zookeeper: make error messages more informative. #

Patch Set 4 : zookeeper: make error messages more informative. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -91 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M close_test.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M retry_test.go View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M zk.go View 1 2 31 chunks +104 lines, -72 lines 0 comments Download
M zk_test.go View 1 2 14 chunks +54 lines, -15 lines 0 comments Download

Messages

Total messages: 7
rog
Please take a look.
9 years, 10 months ago (2012-03-15 11:01:55 UTC) #1
niemeyer
Very nice. Just a few ideas. https://codereview.appspot.com/5835045/diff/2001/zk.go File zk.go (right): https://codereview.appspot.com/5835045/diff/2001/zk.go#newcode120 zk.go:120: // HasErrorCode returns ...
9 years, 10 months ago (2012-03-15 14:31:38 UTC) #2
rog
Please take a look.
9 years, 10 months ago (2012-03-15 15:12:23 UTC) #3
rog
https://codereview.appspot.com/5835045/diff/2001/zk.go File zk.go (right): https://codereview.appspot.com/5835045/diff/2001/zk.go#newcode120 zk.go:120: // HasErrorCode returns whether the error has the given ...
9 years, 10 months ago (2012-03-15 15:12:33 UTC) #4
niemeyer
LGTM
9 years, 10 months ago (2012-03-15 15:17:14 UTC) #5
niemeyer
LGTM
9 years, 10 months ago (2012-03-15 15:17:15 UTC) #6
rog
9 years, 10 months ago (2012-03-15 16:04:03 UTC) #7
*** Submitted:

zookeeper: make error messages more informative.

R=niemeyer
CC=
https://codereview.appspot.com/5835045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b