Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 583290043: Fix a few complaints in python/convertrules.py

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 4 days ago by dak
Modified:
1 week ago
Reviewers:
hahnjo
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix a few complaints in python/convertrules.py

Patch Set 1 #

Total comments: 4

Patch Set 2 : Suggestion according to Jonas #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -12 lines) Patch
M python/convertrules.py View 1 4 chunks +6 lines, -12 lines 0 comments Download

Messages

Total messages: 5
hahnjo
https://codereview.appspot.com/583290043/diff/557180043/python/convertrules.py File python/convertrules.py (right): https://codereview.appspot.com/583290043/diff/557180043/python/convertrules.py#newcode1774 python/convertrules.py:1774: str += "'" * (o + 1) I agree ...
1 week, 4 days ago (2020-01-08 08:17:26 UTC) #1
hahnjo
https://codereview.appspot.com/583290043/diff/557180043/python/convertrules.py File python/convertrules.py (right): https://codereview.appspot.com/583290043/diff/557180043/python/convertrules.py#newcode3973 python/convertrules.py:3973: if re.search (r"#(banter|jazz)-chordnames", str): On 2020/01/08 08:17:25, hahnjo wrote: ...
1 week, 4 days ago (2020-01-08 08:20:39 UTC) #2
dak
https://codereview.appspot.com/583290043/diff/557180043/python/convertrules.py File python/convertrules.py (right): https://codereview.appspot.com/583290043/diff/557180043/python/convertrules.py#newcode1774 python/convertrules.py:1774: str += "'" * (o + 1) On 2020/01/08 ...
1 week, 1 day ago (2020-01-12 00:51:26 UTC) #3
dak
Suggestion according to Jonas
1 week ago (2020-01-12 01:57:36 UTC) #4
hahnjo
1 week ago (2020-01-12 10:26:48 UTC) #5
Thanks, LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b