https://codereview.appspot.com/583290043/diff/557180043/python/convertrules.py File python/convertrules.py (right): https://codereview.appspot.com/583290043/diff/557180043/python/convertrules.py#newcode1774 python/convertrules.py:1774: str += "'" * (o + 1) On 2020/01/08 ...
4 years, 2 months ago
(2020-01-12 00:51:26 UTC)
#3
https://codereview.appspot.com/583290043/diff/557180043/python/convertrules.py
File python/convertrules.py (right):
https://codereview.appspot.com/583290043/diff/557180043/python/convertrules.p...
python/convertrules.py:1774: str += "'" * (o + 1)
On 2020/01/08 08:17:25, hahnjo wrote:
> I agree that this is equivalent, but still very confusing. I would propose the
> following which should highlight the intent:
> o += 1
> if o < 0:
> str += ',' * (-o)
> elif o > 0:
> str += "'" * o
I thought about this but then considered it not significantly clearer. Since
the clarity is for readers of code rather than writers, I'll take your opinion
over mine here.
Issue 583290043: Fix a few complaints in python/convertrules.py
(Closed)
Created 4 years, 2 months ago by dak
Modified 4 years, 1 month ago
Reviewers: hahnjo
Base URL:
Comments: 4