Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(848)

Issue 583200043: Issue 5636: fix various warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 months, 3 weeks ago by Dan Eble
Modified:
9 months, 2 weeks ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5636/ 1: int->vsize in Cluster 2: int->vsize in Grob::pure_is_visible () Also, for maintainability, let Item::pure_is_visible () default to Grob::pure_is_visible () rather than use a hard-coded value. 3: more int->vsize in System Doesn't fix any warnings now, but will avoid new ones later. 4: int->long for result of scm_ilength ()

Patch Set 1 : int->vsize in Cluster #

Patch Set 2 : int->vsize in Grob::pure_is_visible () #

Patch Set 3 : more int->vsize in System #

Patch Set 4 : int->long for result of scm_ilength () #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -31 lines) Patch
M lily/cluster.cc View 4 chunks +13 lines, -8 lines 0 comments Download
M lily/dispatcher.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M lily/general-scheme.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M lily/grob.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M lily/include/grob.hh View 1 1 chunk +4 lines, -1 line 0 comments Download
M lily/include/item.hh View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/include/system.hh View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M lily/item.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M lily/lily-guile.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M lily/repeated-music.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M lily/system.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M lily/tab-staff-symbol-engraver.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Dan Eble
int->vsize in Grob::pure_is_visible ()
9 months, 3 weeks ago (2019-12-13 01:37:08 UTC) #1
Dan Eble
more int->vsize in System
9 months, 3 weeks ago (2019-12-13 01:37:53 UTC) #2
Dan Eble
int->long for result of scm_ilength ()
9 months, 3 weeks ago (2019-12-13 01:38:24 UTC) #3
lemzwerg
9 months, 3 weeks ago (2019-12-13 05:10:17 UTC) #4
LGTM, thanks!  Fixing those warnings is a great job.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b