|
Issue 5555: TimeScaledMusic should not be music-wrapper-music
The original title of this issue was "\tweak no longer works with \tuplet".
Still missing is regtest coverage: this would warrant also amending
input/regression/added-post-event-test.ly .
Consists of commits:
Issue 5555/3: TimeScaledMusic should not be music-wrapper-music
The original title of this issue was "\tweak no longer works with \tuplet".
The trigger of the problem is issue 5302 which lets tweaks bypass
expressions marked as music-wrapper-music. \tuplet creates
TimeScaledMusic expressions which take tweaks for applying to the
created TupletBracket and TupletNumber, so this kind of passing on
does not seem appropriate. Removing the music-wrapper-music type has
several other consequences for tuplets:
* Music functions returning or music variables containing a
single-note \tuplet expression can no longer be used inside of a
chord (where their duration would be overriden anyway).
* Post events can no longer be attached to a \tuplet expression as a
whole. Previously, this let them migrate to the last note of the
tuplet expression.
While the former appears to be a non-issue because of being obscure
and basically useless, the latter is addressed with a separate patch.
Issue 5555/2: add_post_events: check for time-scaled-music explicitly
This is in preparation to stopping TimeScaledMusic to be
music-wrapper-music to make sure that things like
\tuplet 3/2 { c' c' } -.
continue being interpreted as
\tuplet 3/2 { c' c'-. }
Issue 5555/1: reorder checks in add_post_events for efficiency
|