Issue 5819049: gtk3: show language name on the IME menu.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5819049: gtk3: show language name on the IME menu. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by Daiki Ueno

Modified:
12 years, 1 month ago

Reviewers:
shawn.p.huang

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

gtk3: show language name on the IME menu. BUG=https://bugzilla.redhat.com/show_bug.cgi?id=803177 TEST=manual

Patch Set 2 : add config.vapi to EXTRA_DIST #

Total comments: 2

Patch Set 3 : use ibus_get_language_name in libibus #

Total comments: 1

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	ui/gtk3/panel.vala	View	1 2	1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Peng

Could you please provide a screenshot for it? https://codereview.appspot.com/5819049/diff/2001/ui/gtk3/language.vala File ui/gtk3/language.vala (right): https://codereview.appspot.com/5819049/diff/2001/ui/gtk3/language.vala#newcode22 ui/gtk3/language.vala:22: We ...

12 years, 1 month ago (2012-03-14 21:27:01 UTC) #2

Daiki Ueno

On 2012/03/14 21:27:01, Peng wrote: > Could you please provide a screenshot for it? before: ...

12 years, 1 month ago (2012-03-15 01:28:21 UTC) #3

Daiki Ueno

On 2012/03/15 01:28:21, Daiki Ueno wrote: > However, the translation looks a bit awkward. Maybe ...

12 years, 1 month ago (2012-03-15 02:28:45 UTC) #4

Peng

12 years, 1 month ago (2012-03-15 04:03:58 UTC) #5

lgtm. With one coding style issue.

https://codereview.appspot.com/5819049/diff/5001/ui/gtk3/panel.vala
File ui/gtk3/panel.vala (right):

https://codereview.appspot.com/5819049/diff/5001/ui/gtk3/panel.vala#newcode335
ui/gtk3/panel.vala:335: var item = new Gtk.ImageMenuItem.with_label("%s -
%s".printf (IBus.get_language_name(language), longname));
This line is too long. Could you make it in 80 columns?

Expand All Messages | Collapse All Messages