Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1109)

Issue 581630043: Drop support for multiple configurations (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by hahnjo
Modified:
4 months, 2 weeks ago
Reviewers:
lemzwerg, carl.d.sorensen, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Drop support for multiple configurations Currently configure has the flag --enable-config=CONF which allows to have multiple configurations in the same directory and choose from them using `make conf=CONF'. This might have been useful in the last century (yes, the flag was really added in 1998 with LilyPond 1.0.1!) ... Nowadays the solution is to just have many build directories, pointing to the same source directory. The additional possibility just complicates the build system and makes future changes harder than necessary.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -86 lines) Patch
M Documentation/contributor/build-notes.itexi View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/included/compile.itexi View 2 chunks +0 lines, -37 lines 2 comments Download
M aclocal.m4 View 7 chunks +6 lines, -20 lines 0 comments Download
M config.make.in View 1 chunk +0 lines, -1 line 0 comments Download
M configure.ac View 4 chunks +6 lines, -8 lines 0 comments Download
M make/stepmake.make View 3 chunks +4 lines, -18 lines 0 comments Download

Messages

Total messages: 5
lemzwerg
LGTM, thanks!
4 months, 4 weeks ago (2020-02-12 16:39:25 UTC) #1
Carl
I really like the work. I just wonder if we should eliminate the instructions on ...
4 months, 4 weeks ago (2020-02-12 16:50:31 UTC) #2
hanwenn
Oh no! I was using this just this week for GUILE2 vs GUILE1.8 (but OK ...
4 months, 4 weeks ago (2020-02-12 20:43:51 UTC) #3
hanwenn
https://codereview.appspot.com/581630043/diff/563520043/Documentation/included/compile.itexi File Documentation/included/compile.itexi (left): https://codereview.appspot.com/581630043/diff/563520043/Documentation/included/compile.itexi#oldcode895 Documentation/included/compile.itexi:895: @node Compiling for multiple platforms On 2020/02/12 16:50:30, Carl ...
4 months, 4 weeks ago (2020-02-12 20:45:31 UTC) #4
hahnjo
4 months, 4 weeks ago (2020-02-13 08:05:04 UTC) #5
On 2020/02/12 20:45:31, hanwenn wrote:
>
https://codereview.appspot.com/581630043/diff/563520043/Documentation/include...
> File Documentation/included/compile.itexi (left):
> 
>
https://codereview.appspot.com/581630043/diff/563520043/Documentation/include...
> Documentation/included/compile.itexi:895: @node Compiling for multiple
platforms
> On 2020/02/12 16:50:30, Carl wrote:
> > I wonder if we should keep the heading "Compiling for multiple platforms",
and
> > just have it say "Use a separate build directory for each different
platform,
> > and run configure in each build directory."  Perhaps even use the same
> example,
> > and show how to handle this situation.
> 
> people that need to do this are probably expert enough to already know how to
> achieve it.

Right, this is core functionality from Autoconf and described in their
documentation. Additionally I don't think "multiple platforms" is a thing
nowadays - there's x86_64 and that's mostly it what you compile on a single
system.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b