Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(709)

Issue 581570043: Document 2 functions in markup-macros.scm (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months ago by hanwenn
Modified:
7 months, 3 weeks ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Document 2 functions in markup-macros.scm

Patch Set 1 #

Total comments: 4

Patch Set 2 : werner comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M scm/markup-macros.scm View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8
lemzwerg
Some nits. https://codereview.appspot.com/581570043/diff/563450043/scm/markup-macros.scm File scm/markup-macros.scm (right): https://codereview.appspot.com/581570043/diff/563450043/scm/markup-macros.scm#newcode419 scm/markup-macros.scm:419: "Lookup procedure in the current module, or ...
8 months ago (2020-02-01 07:04:11 UTC) #1
hanwenn
werner comments
8 months ago (2020-02-01 21:14:13 UTC) #2
hanwenn
https://codereview.appspot.com/581570043/diff/563450043/scm/markup-macros.scm File scm/markup-macros.scm (right): https://codereview.appspot.com/581570043/diff/563450043/scm/markup-macros.scm#newcode419 scm/markup-macros.scm:419: "Lookup procedure in the current module, or return #f" ...
8 months ago (2020-02-01 21:15:10 UTC) #3
lemzwerg
On 2020/02/01 21:15:10, hanwenn wrote: > https://codereview.appspot.com/581570043/diff/563450043/scm/markup-macros.scm > File scm/markup-macros.scm (right): > > https://codereview.appspot.com/581570043/diff/563450043/scm/markup-macros.scm#newcode419 > ...
8 months ago (2020-02-01 22:33:09 UTC) #4
lemzwerg
> you need to read the comment at the top of the file too.. Well, ...
8 months ago (2020-02-01 22:35:38 UTC) #5
hanwenn
On 2020/02/01 22:35:38, lemzwerg wrote: > > you need to read the comment at the ...
7 months, 4 weeks ago (2020-02-02 15:16:55 UTC) #6
hanwenn
*say
7 months, 4 weeks ago (2020-02-02 15:17:04 UTC) #7
lemzwerg
7 months, 4 weeks ago (2020-02-02 19:15:24 UTC) #8
On 2020/02/02 15:17:04, hanwenn wrote:
> *say

Yep, LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b