Document 2 functions in markup-macros.scm

Document 2 functions in markup-macros.scm

[lemzwerg, 2020-02-01 07:04:11]

Some nits.

https://codereview.appspot.com/581570043/diff/563450043/scm/markup-macros.scm
File scm/markup-macros.scm (right):

https://codereview.appspot.com/581570043/diff/563450043/scm/markup-macros.scm...
scm/markup-macros.scm:419: "Lookup procedure in the current module, or return
#f"
s/Lookup/Look up/

https://codereview.appspot.com/581570043/diff/563450043/scm/markup-macros.scm...
scm/markup-macros.scm:427: "Return (PROC . SIG) for a markup command, or return
#f"
Mhmm, what is 'PROC', what is 'SIG'?  For me, this doc string is still too
terse...

[hanwenn, 2020-02-01 21:14:13]

werner comments

[hanwenn, 2020-02-01 21:15:10]

https://codereview.appspot.com/581570043/diff/563450043/scm/markup-macros.scm
File scm/markup-macros.scm (right):

https://codereview.appspot.com/581570043/diff/563450043/scm/markup-macros.scm...
scm/markup-macros.scm:419: "Lookup procedure in the current module, or return
#f"
On 2020/02/01 07:04:11, lemzwerg wrote:
> s/Lookup/Look up/

Done.

https://codereview.appspot.com/581570043/diff/563450043/scm/markup-macros.scm...
scm/markup-macros.scm:427: "Return (PROC . SIG) for a markup command, or return
#f"
On 2020/02/01 07:04:11, lemzwerg wrote:
> Mhmm, what is 'PROC', what is 'SIG'?  For me, this doc string is still too
> terse...

you need to read the comment at the top of the file too..

I think this function should not have been pulbic, and suspect it is only so
some of the macros can work.

[lemzwerg, 2020-02-01 22:33:09]

On 2020/02/01 21:15:10, hanwenn wrote:
> https://codereview.appspot.com/581570043/diff/563450043/scm/markup-macros.scm
> File scm/markup-macros.scm (right):
> 
>
https://codereview.appspot.com/581570043/diff/563450043/scm/markup-macros.scm...
> scm/markup-macros.scm:419: "Lookup procedure in the current module, or return
> #f"
> On 2020/02/01 07:04:11, lemzwerg wrote:
> > s/Lookup/Look up/
> 
> Done.
> 
>
https://codereview.appspot.com/581570043/diff/563450043/scm/markup-macros.scm...
> scm/markup-macros.scm:427: "Return (PROC . SIG) for a markup command, or
return
> #f"
> On 2020/02/01 07:04:11, lemzwerg wrote:
> > Mhmm, what is 'PROC', what is 'SIG'?  For me, this doc string is still too
> > terse...
> 
> you need to read the comment at the top of the file too..
> 
> I think this function should not have been pulbic, and suspect it is only so
> some of the macros can work.

[lemzwerg, 2020-02-01 22:35:38]

> you need to read the comment at the top of the file too..

Well, ...

> I think this function should not have been pulbic,
> and suspect it is only so some of the macros can work.

... even a non-public function should have an understandable doc string, so
thanks for the fix!

[hanwenn, 2020-02-02 15:16:55]

On 2020/02/01 22:35:38, lemzwerg wrote:
> > you need to read the comment at the top of the file too..
> 
> Well, ...
> 
> > I think this function should not have been pulbic,
> > and suspect it is only so some of the macros can work.
> 
> ... even a non-public function should have an understandable doc string, so
> thanks for the fix!

you're welcome. Did you mean to see LGTM?

[hanwenn, 2020-02-02 15:17:04]

*say

[lemzwerg, 2020-02-02 19:15:24]

On 2020/02/02 15:17:04, hanwenn wrote:
> *say

Yep, LGTM.