Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(256)

Issue 581470047: Set page breaking properties in the System grob (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 2 months ago by hanwenn
Modified:
4 years, 1 month ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Set page breaking properties in the System grob * Record system rank within page in rank-on-page property * Record page number in page-number property

Patch Set 1 #

Total comments: 1

Patch Set 2 : l -> lilne #

Patch Set 3 : system.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M lily/page-breaking.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M lily/system.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M scm/define-grob-properties.scm View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Dan Eble
What's the purpose of this change? Is it preparation for a new feature? https://codereview.appspot.com/581470047/diff/565490043/lily/page-breaking.cc File ...
4 years, 2 months ago (2020-01-22 16:20:21 UTC) #1
Erlend Aasland
On 2020/01/22 16:20:21, Dan Eble wrote: > Veto! I've had more than one bad experience ...
4 years, 2 months ago (2020-01-22 18:51:07 UTC) #2
dak
On 2020/01/22 18:51:07, Erlend Aasland wrote: > On 2020/01/22 16:20:21, Dan Eble wrote: > > ...
4 years, 2 months ago (2020-01-22 19:05:51 UTC) #3
hanwenn
l -> lilne
4 years, 2 months ago (2020-01-22 19:52:23 UTC) #4
hanwenn
4 years, 2 months ago (2020-01-22 20:38:00 UTC) #5
system.cc
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b