Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5561)

Issue 581110043: Allow slurs instead of brackets with tuplets

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 2 weeks ago by lemzwerg
Modified:
1 month, 2 weeks ago
Reviewers:
dak, Malte Meyn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Allow slurs instead of brackets with tuplets Older editions often use slurs with tuplets. This patch creates a new property ('tuplet-slur'), which toggles this notation style. Note that 'bracket-visibility must be set to #t for the slurs to appear with beamed notes. (In the future, 'bracket-visibility might automatically be set to #t.)

Patch Set 1 #

Patch Set 2 : Ligature brackets fix. #

Total comments: 3

Patch Set 3 : Fix regression snippet version strings. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -37 lines) Patch
A input/regression/tuplet-slur-tweaks.ly View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A input/regression/tuplet-slurs.ly View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
M lily/tuplet-bracket.cc View 6 chunks +100 lines, -37 lines 0 comments Download
M scm/define-grob-properties.scm View 1 chunk +2 lines, -0 lines 0 comments Download
M scm/define-grobs.scm View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6
lemzwerg
Ligature brackets fix.
1 month, 2 weeks ago (2019-10-06 16:03:41 UTC) #1
Malte Meyn
https://codereview.appspot.com/581110043/diff/569040043/input/regression/tuplet-slur-tweaks.ly File input/regression/tuplet-slur-tweaks.ly (right): https://codereview.appspot.com/581110043/diff/569040043/input/regression/tuplet-slur-tweaks.ly#newcode1 input/regression/tuplet-slur-tweaks.ly:1: \version "2.19.55" Shouldn’t this be 2.21.0? https://codereview.appspot.com/581110043/diff/569040043/input/regression/tuplet-slurs.ly File input/regression/tuplet-slurs.ly ...
1 month, 2 weeks ago (2019-10-07 14:02:46 UTC) #2
dak
https://codereview.appspot.com/581110043/diff/569040043/input/regression/tuplet-slur-tweaks.ly File input/regression/tuplet-slur-tweaks.ly (right): https://codereview.appspot.com/581110043/diff/569040043/input/regression/tuplet-slur-tweaks.ly#newcode1 input/regression/tuplet-slur-tweaks.ly:1: \version "2.19.55" On 2019/10/07 14:02:46, Malte Meyn wrote: > ...
1 month, 2 weeks ago (2019-10-07 15:01:56 UTC) #3
Malte Meyn
On 2019/10/07 15:01:56, dak wrote: > https://codereview.appspot.com/581110043/diff/569040043/input/regression/tuplet-slur-tweaks.ly > File input/regression/tuplet-slur-tweaks.ly (right): > > https://codereview.appspot.com/581110043/diff/569040043/input/regression/tuplet-slur-tweaks.ly#newcode1 > ...
1 month, 2 weeks ago (2019-10-07 15:26:21 UTC) #4
dak
lilypond@maltemeyn.de writes: > On 2019/10/07 15:01:56, dak wrote: > > https://codereview.appspot.com/581110043/diff/569040043/input/regression/tuplet-slur-tweaks.ly >> File input/regression/tuplet-slur-tweaks.ly (right): ...
1 month, 2 weeks ago (2019-10-07 16:21:41 UTC) #5
lemzwerg
1 month, 2 weeks ago (2019-10-08 09:23:05 UTC) #6
Fix regression snippet version strings.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b