Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2230)

Issue 581080044: Issue 5565: simplify python-related makefiles (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by Dan Eble
Modified:
4 years, 6 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5565/ Avoid encoding unnecessary details of Python compilation into the build rules. Remove some cruft. I hope that these changes will work equally well with Python 2 and 3, but I have only tested in an environment with 2.

Patch Set 1 #

Total comments: 1

Patch Set 2 : move DELETE_ON_ERROR to stepmake.make #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -30 lines) Patch
M make/stepmake.make View 1 1 chunk +4 lines, -0 lines 0 comments Download
M stepmake/stepmake/python-module-rules.make View 1 1 chunk +7 lines, -12 lines 0 comments Download
M stepmake/stepmake/python-module-targets.make View 1 chunk +1 line, -1 line 0 comments Download
M stepmake/stepmake/python-module-vars.make View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 4
Dan Eble
4 years, 6 months ago (2019-10-02 22:12:38 UTC) #1
lemzwerg
LGTM. https://codereview.appspot.com/581080044/diff/578940043/stepmake/stepmake/python-module-rules.make File stepmake/stepmake/python-module-rules.make (right): https://codereview.appspot.com/581080044/diff/578940043/stepmake/stepmake/python-module-rules.make#newcode1 stepmake/stepmake/python-module-rules.make:1: .DELETE_ON_ERROR: Looking into the info file of make ...
4 years, 6 months ago (2019-10-03 04:27:01 UTC) #2
Dan Eble
On 2019/10/03 04:27:01, lemzwerg wrote: > Looking into the info file of make it seems ...
4 years, 6 months ago (2019-10-03 12:02:58 UTC) #3
Dan Eble
4 years, 6 months ago (2019-10-03 18:27:18 UTC) #4
move DELETE_ON_ERROR to stepmake.make
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b