Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(21)

Issue 58050043: Replaced JsZip with Dart package:archive. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by pajamallama
Modified:
10 years, 3 months ago
Reviewers:
tapted
CC:
chrome-apps-internsyd_google.com
Base URL:
https://github.com/tapted/bleeding_edge.git@master
Visibility:
Public.

Description

Replaced JsZip with Dart package:archive. Now the submodule for JsZip has been removed, as has the need for any JavaScript code (except the background page). Therefore the jsProxy and the .o hackery has been cleaned up. Also now the code requests tar.gz files from the server instead of uncompressed zip files. I've tested that now tavern works perfectly with the pub server. Addition permissions were added to the manifest file so that downloading from pub is working. R=tapted@chromium.org Committed: https://github.com/tapted/bleeding_edge/commit/88b5f9a

Patch Set 1 #

Total comments: 4

Patch Set 2 : Removed .gitmodules & cleaned up hosted.dart: get function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -190 lines) Patch
M .gitmodules View 1 1 chunk +0 lines, -3 lines 0 comments Download
M dart/sdk/lib/_internal/pub/Makefile View 2 chunks +1 line, -5 lines 0 comments Download
D dart/sdk/lib/_internal/pub/js/archive.js View 1 chunk +0 lines, -74 lines 0 comments Download
D dart/sdk/lib/_internal/pub/lib/archive.js View 1 chunk +0 lines, -74 lines 0 comments Download
M dart/sdk/lib/_internal/pub/lib/src/pubspec.yaml View 1 chunk +4 lines, -8 lines 0 comments Download
M dart/sdk/lib/_internal/pub/lib/src/source/hosted.dart View 1 1 chunk +5 lines, -10 lines 0 comments Download
M dart/sdk/lib/_internal/pub/lib/src/wrap/http_wrap.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M dart/sdk/lib/_internal/pub/lib/src/wrap/io_wrap.dart View 3 chunks +14 lines, -10 lines 0 comments Download
M dart/sdk/lib/_internal/pub/manifest.json View 1 chunk +3 lines, -1 line 0 comments Download
M dart/sdk/lib/_internal/pub/pub.html View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4
pajamallama
This package is **awesome**.
10 years, 3 months ago (2014-01-28 23:52:43 UTC) #1
tapted
lgtm https://codereview.appspot.com/58050043/diff/1/.gitmodules File .gitmodules (left): https://codereview.appspot.com/58050043/diff/1/.gitmodules#oldcode1 .gitmodules:1: [submodule "dart/sdk/lib/_internal/pub/js/jszip"] I think this is leaving an ...
10 years, 3 months ago (2014-01-29 00:14:25 UTC) #2
pajamallama
https://codereview.appspot.com/58050043/diff/1/.gitmodules File .gitmodules (left): https://codereview.appspot.com/58050043/diff/1/.gitmodules#oldcode1 .gitmodules:1: [submodule "dart/sdk/lib/_internal/pub/js/jszip"] On 2014/01/29 00:14:25, tapted wrote: > I ...
10 years, 3 months ago (2014-01-29 00:26:09 UTC) #3
pajamallama
10 years, 3 months ago (2014-01-29 00:27:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r88b5f9a.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b