Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(116)

Issue 579280043: Doc: Some miscellaneous suggestions from Peter Toye

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 2 weeks ago by michael.kaeppler
Modified:
3 months ago
Reviewers:
xmichael-k, wl, carl.d.sorensen, lemzwerg, lilypond, Dan Eble, dak, thomasmorley651, Jean-Charles
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: Some miscellaneous suggestions from Peter Toye Peter Toye suggested some additions/corrections to the manuals a while ago in https://lists.gnu.org/archive/html/lilypond-devel/2019-12/msg00191.html and https://lists.gnu.org/archive/html/bug-lilypond/2020-02/msg00010.html He does not have the time to create a patch, so I prepared one for him, mostly following his suggestions. Sorry for the ambigous patch description.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove note about MIDI and bar number checks, combine Werner's and Peter's notes on variable names #

Patch Set 3 : Further adjustments in consequence of Peter's comments in https://lists.gnu.org/archive/html/lilypo… #

Total comments: 1

Patch Set 4 : Remove non-working cyrillic example #

Total comments: 1

Patch Set 5 : Explain note name parts, remove questionable occurrence of term 'accidental' #

Total comments: 1

Patch Set 6 : Use singular form for index entries #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -12 lines) Patch
M Documentation/learning/common-notation.itely View 1 2 3 4 2 chunks +12 lines, -6 lines 0 comments Download
M Documentation/learning/tutorial.itely View 1 2 1 chunk +7 lines, -2 lines 0 comments Download
M Documentation/notation/input.itely View 1 2 3 4 5 3 chunks +22 lines, -4 lines 0 comments Download

Messages

Total messages: 40
michael.kaeppler
3 months, 2 weeks ago (2020-02-05 12:59:21 UTC) #1
Dan Eble
https://codereview.appspot.com/579280043/diff/579290043/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): https://codereview.appspot.com/579280043/diff/579290043/Documentation/notation/rhythms.itely#newcode3325 Documentation/notation/rhythms.itely:3325: bar number check may fail. It is best to ...
3 months, 2 weeks ago (2020-02-05 14:14:47 UTC) #2
lemzwerg
A nit. https://codereview.appspot.com/579280043/diff/579290043/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/579280043/diff/579290043/Documentation/notation/input.itely#newcode464 Documentation/notation/input.itely:464: escaped with backslashes. This is confusing. 'Alphabetic ...
3 months, 2 weeks ago (2020-02-05 14:51:03 UTC) #3
michael.kaeppler
On 2020/02/05 14:14:47, Dan Eble wrote: > https://codereview.appspot.com/579280043/diff/579290043/Documentation/notation/rhythms.itely > File Documentation/notation/rhythms.itely (right): > > https://codereview.appspot.com/579280043/diff/579290043/Documentation/notation/rhythms.itely#newcode3325 ...
3 months, 2 weeks ago (2020-02-05 21:18:19 UTC) #4
michael.kaeppler
On 2020/02/05 14:51:03, lemzwerg wrote: > A nit. > > https://codereview.appspot.com/579280043/diff/579290043/Documentation/notation/input.itely > File Documentation/notation/input.itely (right): ...
3 months, 2 weeks ago (2020-02-05 21:48:29 UTC) #5
michael.kaeppler
Remove note about MIDI and bar number checks, combine Werner's and Peter's notes on variable ...
3 months, 2 weeks ago (2020-02-05 21:51:09 UTC) #6
michael.kaeppler
Further adjustments in consequence of Peter's comments in https://lists.gnu.org/archive/html/lilypond-devel/2020-02/msg00265.html
3 months, 2 weeks ago (2020-02-05 22:18:19 UTC) #7
lemzwerg
An important nit to check... Besides this, LGTM, thanks! https://codereview.appspot.com/579280043/diff/567170044/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/579280043/diff/567170044/Documentation/notation/input.itely#newcode464 Documentation/notation/input.itely:464: ...
3 months, 2 weeks ago (2020-02-06 15:00:35 UTC) #8
lilypond_ptoye.com
------------------------- Thursday, February 6, 2020, 3:00:35 PM, you wrote: > An important nit to check... ...
3 months, 2 weeks ago (2020-02-06 16:57:21 UTC) #9
michael.kaeppler
Remove non-working cyrillic example
3 months, 2 weeks ago (2020-02-06 21:10:29 UTC) #10
michael.kaeppler
On 2020/02/06 15:00:35, lemzwerg wrote: > An important nit to check... > > Besides this, ...
3 months, 2 weeks ago (2020-02-06 21:14:00 UTC) #11
thomasmorley651
https://codereview.appspot.com/579280043/diff/563480043/Documentation/learning/common-notation.itely File Documentation/learning/common-notation.itely (right): https://codereview.appspot.com/579280043/diff/563480043/Documentation/learning/common-notation.itely#newcode162 Documentation/learning/common-notation.itely:162: @notation{note names} and @notation{accidentals}, Here I disagree. From wikpedia ...
3 months, 2 weeks ago (2020-02-06 21:55:40 UTC) #12
lilypond_ptoye.com
Thursday, February 6, 2020, 9:14:00 PM, you wrote: > On 2020/02/06 15:00:35, lemzwerg wrote: >> ...
3 months, 2 weeks ago (2020-02-07 18:01:09 UTC) #13
xmichael-k
Am 06.02.2020 um 22:55 schrieb thomasmorley65@gmail.com: > https://codereview.appspot.com/579280043/diff/563480043/Documentation/learning/common-notation.itely > File Documentation/learning/common-notation.itely (right): > > https://codereview.appspot.com/579280043/diff/563480043/Documentation/learning/common-notation.itely#newcode162 ...
3 months, 2 weeks ago (2020-02-07 20:39:39 UTC) #14
wl_gnu.org
> Теноры > Very odd - I've just installed a CMU font and it's got ...
3 months, 2 weeks ago (2020-02-08 05:03:36 UTC) #15
lilypond_ptoye.com
------------------------- Saturday, February 8, 2020, 5:03:15 AM, you wrote: >> Теноры >> Very odd - ...
3 months, 2 weeks ago (2020-02-08 12:40:16 UTC) #16
wl_gnu.org
>>> See the line above which is in CMU Concrete! > >> ??? I use ...
3 months, 2 weeks ago (2020-02-08 18:07:35 UTC) #17
lilypond_ptoye.com
Saturday, February 8, 2020, 6:07:23 PM, you wrote: >>>> See the line above which is ...
3 months, 2 weeks ago (2020-02-09 12:02:09 UTC) #18
thomasmorley651
I'd love to see more opinions about comments #12 and #14. Otherwise I'd object to ...
3 months, 2 weeks ago (2020-02-09 12:33:23 UTC) #19
dak
On 2020/02/09 12:33:23, thomasmorley651 wrote: > I'd love to see more opinions about comments #12 ...
3 months, 2 weeks ago (2020-02-09 12:51:57 UTC) #20
lemzwerg
> > I'd love to see more opinions about comments #12 and #14. > > ...
3 months, 2 weeks ago (2020-02-09 12:55:46 UTC) #21
lilypond_ptoye.com
------------------------- Friday, February 7, 2020, 8:39:36 PM, you wrote: > Am 06.02.2020 um 22:55 schrieb ...
3 months, 2 weeks ago (2020-02-09 13:23:44 UTC) #22
Carl
I'm a native US speaker. The following is my opinion. Alteration is a change in ...
3 months, 2 weeks ago (2020-02-09 14:16:51 UTC) #23
lilypond_ptoye.com
Sunday, February 9, 2020, 2:16:50 PM, you wrote: > I'm a native US speaker. The ...
3 months, 2 weeks ago (2020-02-09 15:32:14 UTC) #24
Carl
On 2020/02/09 15:32:14, lilypond_ptoye.com wrote: > Sunday, February 9, 2020, 2:16:50 PM, you wrote: > ...
3 months, 2 weeks ago (2020-02-09 16:10:46 UTC) #25
thomasmorley651
On 2020/02/09 15:32:14, lilypond_ptoye.com wrote: > Surely "standard scale pitch or previously altered pitch". In ...
3 months, 2 weeks ago (2020-02-09 16:15:53 UTC) #26
lilypond_ptoye.com
Sunday, February 9, 2020, 4:15:53 PM, you wrote: > On 2020/02/09 15:32:14, lilypond_ptoye.com wrote: >> ...
3 months, 2 weeks ago (2020-02-09 17:55:12 UTC) #27
michael.kaeppler
On 2020/02/09 14:16:51, Carl wrote: > I'm a native US speaker. The following is my ...
3 months, 2 weeks ago (2020-02-10 21:40:54 UTC) #28
michael.kaeppler
On 2020/02/09 16:15:53, thomasmorley651 wrote: > On 2020/02/09 15:32:14, http://lilypond_ptoye.com wrote: > > > Surely ...
3 months, 2 weeks ago (2020-02-10 22:00:04 UTC) #29
dak
On 2020/02/10 22:00:04, michael.kaeppler wrote: > However, I think that the description of LilyPond's internal ...
3 months, 2 weeks ago (2020-02-10 22:10:59 UTC) #30
lilypond_ptoye.com
Monday, February 10, 2020, 9:40:53 PM, you wrote: > On 2020/02/09 14:16:51, Carl wrote: >> ...
3 months, 1 week ago (2020-02-11 10:48:18 UTC) #31
michael.kaeppler
Explain note name parts, remove questionable occurrence of term 'accidental'
3 months, 1 week ago (2020-02-11 10:56:52 UTC) #32
Jean-Charles
Have a look at Documentation/HOWTO.index https://codereview.appspot.com/579280043/diff/563510048/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/579280043/diff/563510048/Documentation/notation/input.itely#newcode880 Documentation/notation/input.itely:880: @cindex footers, page Index ...
3 months, 1 week ago (2020-02-11 11:04:59 UTC) #33
lilypond_ptoye.com
Monday, February 10, 2020, 10:00:03 PM, you wrote: > On 2020/02/09 16:15:53, thomasmorley651 wrote: >> ...
3 months, 1 week ago (2020-02-11 11:22:40 UTC) #34
michael.kaeppler
Use singular form for index entries
3 months, 1 week ago (2020-02-11 11:46:27 UTC) #35
michael.kaeppler
On 2020/02/11 11:04:59, Jean-Charles wrote: > Have a look at Documentation/HOWTO.index > > https://codereview.appspot.com/579280043/diff/563510048/Documentation/notation/input.itely > ...
3 months, 1 week ago (2020-02-11 11:47:08 UTC) #36
michael.kaeppler
On 2020/02/11 11:22:40, lilypond_ptoye.com wrote: > Monday, February 10, 2020, 10:00:03 PM, you wrote: > ...
3 months, 1 week ago (2020-02-11 11:59:18 UTC) #37
lilypond_ptoye.com
Tuesday, February 11, 2020, 11:59:18 AM, you wrote: > On 2020/02/11 11:22:40, lilypond_ptoye.com wrote: >> ...
3 months, 1 week ago (2020-02-11 12:23:38 UTC) #38
michael.kaeppler
This patch has already been counted down, however, I would like to have at least ...
3 months ago (2020-02-18 10:20:31 UTC) #39
Dan Eble
3 months ago (2020-02-18 12:10:30 UTC) #40
On 2020/02/18 10:20:31, michael.kaeppler wrote:
> This patch has already been counted down, however, I would
> like to have at least one LGTM to the last version of this patch before
pushing
> this. 
> Knowing that this is only an intermediate state and further clarification
would
> help.

I skimmed it.  LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b