Issue 579042: Dont use start and end beacon in chain proxy url

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 579042: Dont use start and end beacon in chain proxy url

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by zhoresh

Modified:
14 years, 1 month ago

Reviewers:
johnfargo, Paul Lindner, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

For backward compatibility lets keep previous proxy chain structure and do not use star and end beacon in url.

Patch Set 1 #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -30 lines)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java	View		6 chunks	+22 lines, -17 lines	0 comments	Download
		java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManagerTest.java	View		5 chunks	+9 lines, -13 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

johnfargo

14 years, 1 month ago (2010-03-16 23:53:55 UTC) #3

LGTM as well. Patch committed, thanks!

On Tue, Mar 16, 2010 at 3:08 PM, <lindner@inuus.com> wrote:

> lgtm.
>
> thanks!
>
>
> http://codereview.appspot.com/579042/show
>

Expand All Messages | Collapse All Messages