Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(25)

Issue 5787068: zookeeper: allow CreateServer to work in an existing directory.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by rog
Modified:
10 years, 3 months ago
Reviewers:
mp+96778
Visibility:
Public.

Description

It only succeeds if the directory is empty, for instance when it's created by ioutil.TempDir. Also add Server.Addr method and change the NotRunning error to ErrNotRunning. https://code.launchpad.net/~rogpeppe/gozk/allow-existing-server-dir/+merge/96778 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : zookeeper: allow CreateServer to work in an existing directory. #

Total comments: 4

Patch Set 3 : zookeeper: allow CreateServer to work in an existing directory. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -11 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M runserver.go View 1 2 5 chunks +9 lines, -7 lines 0 comments Download
M server.go View 1 2 3 chunks +24 lines, -4 lines 0 comments Download
M server_test.go View 1 2 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 5
rog
Please take a look.
10 years, 3 months ago (2012-03-09 15:19:45 UTC) #1
fwereade
LGTM https://codereview.appspot.com/5787068/diff/5/runserver.go File runserver.go (right): https://codereview.appspot.com/5787068/diff/5/runserver.go#newcode20 runserver.go:20: var ErrNotRunning = errors.New("process not running") I'm not ...
10 years, 3 months ago (2012-03-12 10:34:46 UTC) #2
rog
forgot to publish this. https://codereview.appspot.com/5787068/diff/5/runserver.go File runserver.go (right): https://codereview.appspot.com/5787068/diff/5/runserver.go#newcode20 runserver.go:20: var ErrNotRunning = errors.New("process not ...
10 years, 3 months ago (2012-03-13 11:27:14 UTC) #3
niemeyer
LGTM https://codereview.appspot.com/5787068/diff/5/runserver.go File runserver.go (right): https://codereview.appspot.com/5787068/diff/5/runserver.go#newcode20 runserver.go:20: var ErrNotRunning = errors.New("process not running") On 2012/03/13 ...
10 years, 3 months ago (2012-03-13 21:02:36 UTC) #4
rog
10 years, 3 months ago (2012-03-14 09:43:54 UTC) #5
*** Submitted:

zookeeper: allow CreateServer to work in an existing directory.

It only succeeds if the directory is empty, for instance
when it's created by ioutil.TempDir.

Also add Server.Addr method and change the NotRunning
error to ErrNotRunning.

R=fwereade, niemeyer
CC=
https://codereview.appspot.com/5787068
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b