Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(51)

Issue 5786051: Move ZK test server setup into its own package

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by fwereade
Modified:
7 years, 8 months ago
Reviewers:
mp+96541
Visibility:
Public.

Description

...because other packages will want to test against real States, and I don't want to duplicate the code. https://code.launchpad.net/~fwereade/juju/go-testutil/+merge/96541 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Move ZK test server setup into its own package #

Patch Set 3 : Move ZK test server setup into its own package #

Patch Set 4 : Move ZK test server setup into its own package #

Total comments: 7

Patch Set 5 : Move ZK test server setup into its own package #

Total comments: 2

Patch Set 6 : Move ZK test server setup into its own package #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -45 lines) Patch
A [revision details] View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M state/export_test.go View 1 2 3 4 5 1 chunk +0 lines, -35 lines 0 comments Download
M state/internal_test.go View 1 2 3 4 5 3 chunks +4 lines, -3 lines 0 comments Download
M state/state_test.go View 1 2 3 4 5 3 chunks +12 lines, -7 lines 0 comments Download
A testing/zk.go View 1 2 3 4 5 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 10
fwereade
Please take a look.
7 years, 8 months ago (2012-03-08 10:50:57 UTC) #1
fwereade
Please take a look.
7 years, 8 months ago (2012-03-08 14:20:31 UTC) #2
fwereade
Please take a look.
7 years, 8 months ago (2012-03-08 14:38:40 UTC) #3
niemeyer
On 2012/03/08 14:38:40, fwereade wrote: > Please take a look. There's something going wrong with ...
7 years, 8 months ago (2012-03-12 19:47:53 UTC) #4
fwereade
Please take a look.
7 years, 8 months ago (2012-03-12 23:04:57 UTC) #5
niemeyer
https://codereview.appspot.com/5786051/diff/9002/state/internal_test.go File state/internal_test.go (right): https://codereview.appspot.com/5786051/diff/9002/state/internal_test.go#newcode22 state/internal_test.go:22: _ = Suite(&TopologySuite{}) For some reason this doesn't look ...
7 years, 8 months ago (2012-03-12 23:20:46 UTC) #6
fwereade
https://codereview.appspot.com/5786051/diff/9002/state/internal_test.go File state/internal_test.go (right): https://codereview.appspot.com/5786051/diff/9002/state/internal_test.go#newcode22 state/internal_test.go:22: _ = Suite(&TopologySuite{}) On 2012/03/12 23:20:46, niemeyer wrote: > ...
7 years, 8 months ago (2012-03-13 09:41:25 UTC) #7
fwereade
Please take a look.
7 years, 8 months ago (2012-03-13 09:42:46 UTC) #8
niemeyer
LGTM, with only a few trivials: https://codereview.appspot.com/5786051/diff/9002/testing/zk.go File testing/zk.go (right): https://codereview.appspot.com/5786051/diff/9002/testing/zk.go#newcode16 testing/zk.go:16: dir, err := ...
7 years, 8 months ago (2012-03-13 21:08:06 UTC) #9
fwereade
7 years, 8 months ago (2012-03-15 12:05:53 UTC) #10
*** Submitted:

Move ZK test server setup into its own package

...because other packages will want to test against real States, and I don't
want to duplicate the code.

R=niemeyer
CC=
https://codereview.appspot.com/5786051
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b