Issue 5784079: test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by igor.budasov

Modified:
1 week, 3 days ago

Reviewers:
igor.budasov

Base URL:
test

Visibility:
Public.

Description

test

Patch Set 1 #

Total comments: 5

Created: 11 years ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+24 lines, -18 lines)			Patch
application/modules/store/views/goods/front.tpl	View	1 chunk	+3 lines, -1 line	1 comment	Download
application/system/config.php	View	2 chunks	+2 lines, -2 lines	0 comments	Download
design/css/profit.css	View	1 chunk	+1 line, -1 line	1 comment	Download
design/css/style.css	View	9 chunks	+17 lines, -13 lines	1 comment	Download
design/scripts/header.tpl	View	1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

igor.budasov

11 years ago (2012-03-14 19:36:34 UTC) #2

http://codereview.appspot.com/5784079/diff/1/application/modules/store/views/...
File application/modules/store/views/goods/front.tpl (right):

http://codereview.appspot.com/5784079/diff/1/application/modules/store/views/...
application/modules/store/views/goods/front.tpl:24: +                       
<span class="price">
не нужно использовать этот класс. 
Этот класс - для ценника товара в категории.
Тут я просил тебя сделать большие оранжевые цифры без фона, такого размера как
заголовок товара

http://codereview.appspot.com/5784079/diff/1/design/css/profit.css
File design/css/profit.css (right):

http://codereview.appspot.com/5784079/diff/1/design/css/profit.css#newcode71
design/css/profit.css:71: +	width: 100%;
что это и зачем?

http://codereview.appspot.com/5784079/diff/1/design/css/style.css
File design/css/style.css (left):

http://codereview.appspot.com/5784079/diff/1/design/css/style.css#oldcode945
design/css/style.css:945: .overviewTitle {
названия классов сделай в стиле:
.class-name {
}

http://codereview.appspot.com/5784079/diff/1/design/scripts/header.tpl
File design/scripts/header.tpl (left):

http://codereview.appspot.com/5784079/diff/1/design/scripts/header.tpl#oldcod...
design/scripts/header.tpl:101: -                                           
<input type="text" name="query" id="query" class="search" value=""
maxlength="50">
айдишник убирать нельзя. Он тут не просто так.

http://codereview.appspot.com/5784079/diff/1/design/scripts/header.tpl#oldcod...
design/scripts/header.tpl:101: -                                           
<input type="text" name="query" id="query" class="search" value=""
maxlength="50">
айдишник и исходную верстку не тронь

Expand All Messages | Collapse All Messages