Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(89)

Issue 5784079: test

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by igor.budasov
Modified:
1 year, 3 months ago
Reviewers:
igor.budasov
Base URL:
test
Visibility:
Public.

Description

test

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -18 lines) Patch
application/modules/store/views/goods/front.tpl View 1 chunk +3 lines, -1 line 1 comment Download
application/system/config.php View 2 chunks +2 lines, -2 lines 0 comments Download
design/css/profit.css View 1 chunk +1 line, -1 line 1 comment Download
design/css/style.css View 9 chunks +17 lines, -13 lines 1 comment Download
design/scripts/header.tpl View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 2
igor.budasov
12 years, 3 months ago (2012-03-14 19:30:41 UTC) #1
igor.budasov
12 years, 3 months ago (2012-03-14 19:36:34 UTC) #2
http://codereview.appspot.com/5784079/diff/1/application/modules/store/views/...
File application/modules/store/views/goods/front.tpl (right):

http://codereview.appspot.com/5784079/diff/1/application/modules/store/views/...
application/modules/store/views/goods/front.tpl:24: +                       
<span class="price">
не нужно использовать этот класс. 
Этот класс - для ценника товара в категории.
Тут я просил тебя сделать большие оранжевые цифры без фона, такого размера как
заголовок товара

http://codereview.appspot.com/5784079/diff/1/design/css/profit.css
File design/css/profit.css (right):

http://codereview.appspot.com/5784079/diff/1/design/css/profit.css#newcode71
design/css/profit.css:71: +	width: 100%;
что это и зачем?

http://codereview.appspot.com/5784079/diff/1/design/css/style.css
File design/css/style.css (left):

http://codereview.appspot.com/5784079/diff/1/design/css/style.css#oldcode945
design/css/style.css:945: .overviewTitle {
названия классов сделай в стиле:
.class-name {
}

http://codereview.appspot.com/5784079/diff/1/design/scripts/header.tpl
File design/scripts/header.tpl (left):

http://codereview.appspot.com/5784079/diff/1/design/scripts/header.tpl#oldcod...
design/scripts/header.tpl:101: -                                           
<input type="text" name="query" id="query" class="search" value=""
maxlength="50">
айдишник убирать нельзя. Он тут не просто так.

http://codereview.appspot.com/5784079/diff/1/design/scripts/header.tpl#oldcod...
design/scripts/header.tpl:101: -                                           
<input type="text" name="query" id="query" class="search" value=""
maxlength="50">
айдишник и исходную верстку не тронь
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b