Move CSS Stylesheet Rewriter tests into a JavaScript file

This reworks CssRewriterTest so that we can use tests specified in JavaScript
both in the Java version and to test the JavaScript version.

A later CL will wire the tests into sanitize-css-test.html.

This change also factors out sanitizeCss from html-emitter, moving it to sanitize-css.js.

Submitted @4807

[Jasvir, 2012-03-15 02:44:03]

http://codereview.appspot.com/5784076/diff/1/src/com/google/caja/plugin/sanit...
File src/com/google/caja/plugin/sanitizecss.js (right):

http://codereview.appspot.com/5784076/diff/1/src/com/google/caja/plugin/sanit...
src/com/google/caja/plugin/sanitizecss.js:401: if ('undefined' !== typeof
console) {
Can you add a TODO here to use a logger rather than calling console directly. 
In the playground and other circumstances, these messages might want to be
channeled elsewhere.

http://codereview.appspot.com/5784076/diff/1/src/com/google/caja/plugin/sanit...
src/com/google/caja/plugin/sanitizecss.js:495: sanitizeCssProperty(property,
valueArray, sanitizeUri);
I think you need to pass schema here, not property.  In sanitizeCssProperty,
you're looking up cssPropBits property on the first arg fr'instance.

Hmm, your tests shouldn't be passing in this case.

http://codereview.appspot.com/5784076/diff/1/tests/com/google/caja/plugin/Css...
File tests/com/google/caja/plugin/CssRewriterTest.java (right):

http://codereview.appspot.com/5784076/diff/1/tests/com/google/caja/plugin/Css...
tests/com/google/caja/plugin/CssRewriterTest.java:106: for (Expression testCase
: ((ArrayConstructor) testcases.getValueExpr()).children()) {
wrap.

[MikeSamuel, 2012-03-15 04:19:25]

http://codereview.appspot.com/5784076/diff/1/src/com/google/caja/plugin/sanit...
File src/com/google/caja/plugin/sanitizecss.js (right):

http://codereview.appspot.com/5784076/diff/1/src/com/google/caja/plugin/sanit...
src/com/google/caja/plugin/sanitizecss.js:401: if ('undefined' !== typeof
console) {
On 2012/03/15 02:44:03, Jasvir wrote:
> Can you add a TODO here to use a logger rather than calling console directly. 
> In the playground and other circumstances, these messages might want to be
> channeled elsewhere.

Done.

http://codereview.appspot.com/5784076/diff/1/src/com/google/caja/plugin/sanit...
src/com/google/caja/plugin/sanitizecss.js:495: sanitizeCssProperty(property,
valueArray, sanitizeUri);
On 2012/03/15 02:44:03, Jasvir wrote:
> I think you need to pass schema here, not property.  In sanitizeCssProperty,
> you're looking up cssPropBits property on the first arg fr'instance.
> 
> Hmm, your tests shouldn't be passing in this case.

Done.
The tests aren't wired up to the JS version yet.

http://codereview.appspot.com/5784076/diff/1/tests/com/google/caja/plugin/Css...
File tests/com/google/caja/plugin/CssRewriterTest.java (right):

http://codereview.appspot.com/5784076/diff/1/tests/com/google/caja/plugin/Css...
tests/com/google/caja/plugin/CssRewriterTest.java:106: for (Expression testCase
: ((ArrayConstructor) testcases.getValueExpr()).children()) {
On 2012/03/15 02:44:03, Jasvir wrote:
> wrap.

Done.

[Jasvir, 2012-03-15 05:37:26]

LGTM

A headsup - when debugging a similar change I was making, I found that the
startBlock and endBlock rules never fire in the snippet that you moved from
html-emitter to sanitizecss (and as a result css blocks are missing the
surrounding braces) but I did not manage to get to the bottom of it.  I suspect
that as a result the tests that this change adds will fail when you do wire up
the tests which would be a good time to fix that problem.

[MikeSamuel, 2012-03-15 18:33:08]

2012/3/15  <jasvir@gmail.com>:
> LGTM
>
> A headsup - when debugging a similar change I was making, I found that
> the startBlock and endBlock rules never fire in the snippet that you
> moved from html-emitter to sanitizecss (and as a result css blocks are
> missing the surrounding braces) but I did not manage to get to the
> bottom of it.  I suspect that as a result the tests that this change
> adds will fail when you do wire up the tests which would be a good time
> to fix that problem.
>
> http://codereview.appspot.com/5784076/

Will do.