Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(644)

Issue 5784060: Unbreak goyaml after interface mutability fix in reflect.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by niemeyer
Modified:
9 years, 10 months ago
Reviewers:
mp+96669
Visibility:
Public.

Description

https://code.launchpad.net/~niemeyer/goyaml/interfaces-are-immutable-values/+merge/96669 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Unbreak goyaml after interface mutability fix in reflect. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
A .lbox View 1 chunk +1 line, -0 lines 0 comments Download
M decode.go View 2 chunks +5 lines, -2 lines 0 comments Download
M decode_test.go View 5 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 3
niemeyer
Please take a look.
9 years, 10 months ago (2012-03-08 21:54:00 UTC) #1
rog
On 2012/03/08 21:54:00, niemeyer wrote: > Please take a look. LGTM
9 years, 10 months ago (2012-03-08 22:17:13 UTC) #2
niemeyer
9 years, 10 months ago (2012-03-08 22:29:02 UTC) #3
*** Submitted:

Unbreak goyaml after interface mutability fix in reflect.

R=rog
CC=
https://codereview.appspot.com/5784060
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b